Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

respond to comments #430

Merged
merged 2 commits into from
Dec 6, 2024
Merged

respond to comments #430

merged 2 commits into from
Dec 6, 2024

Conversation

andre-merzky
Copy link
Member

Hey @AymenFJA - of course I forgot to apply your comment on the Pipe PR :-( Sorry for that - here it is though!

@andre-merzky andre-merzky requested a review from AymenFJA December 6, 2024 13:44
@andre-merzky andre-merzky self-assigned this Dec 6, 2024
Copy link

codecov bot commented Dec 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.59%. Comparing base (13d5e69) to head (ae9d9c6).
Report is 3 commits behind head on devel.

Additional details and impacted files
@@            Coverage Diff             @@
##            devel     #430      +/-   ##
==========================================
+ Coverage   61.58%   61.59%   +0.01%     
==========================================
  Files          62       62              
  Lines        7015     7018       +3     
==========================================
+ Hits         4320     4323       +3     
  Misses       2695     2695              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@AymenFJA AymenFJA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks Andre.

@andre-merzky andre-merzky merged commit c5221f1 into devel Dec 6, 2024
11 checks passed
@andre-merzky andre-merzky deleted the fix/poller_instantiation branch December 6, 2024 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants