Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zmq startup is faster than we think #429

Merged
merged 1 commit into from
Dec 3, 2024
Merged

Conversation

andre-merzky
Copy link
Member

This shaves a couple of seconds from session and component startup in RP.

Copy link

codecov bot commented Dec 3, 2024

Codecov Report

Attention: Patch coverage is 57.14286% with 3 lines in your changes missing coverage. Please review.

Project coverage is 61.56%. Comparing base (e0e8158) to head (782352e).
Report is 2 commits behind head on devel.

Files with missing lines Patch % Lines
src/radical/utils/zmq/queue.py 33.33% 2 Missing ⚠️
src/radical/utils/zmq/pubsub.py 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##            devel     #429      +/-   ##
==========================================
- Coverage   61.57%   61.56%   -0.02%     
==========================================
  Files          62       62              
  Lines        6980     6980              
==========================================
- Hits         4298     4297       -1     
- Misses       2682     2683       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@AymenFJA AymenFJA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks Andre.

@andre-merzky andre-merzky merged commit 2f53b82 into devel Dec 3, 2024
11 checks passed
@andre-merzky andre-merzky deleted the fix/zmq_startup_delay branch December 3, 2024 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants