Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/client log #423

Merged
merged 15 commits into from
Oct 25, 2024
Merged

Fix/client log #423

merged 15 commits into from
Oct 25, 2024

Conversation

andre-merzky
Copy link
Member

This supports radical-cybertools/radical.pilot#3244 by passing a logger to a zmq client.

Copy link

codecov bot commented Oct 23, 2024

Codecov Report

Attention: Patch coverage is 87.50000% with 1 line in your changes missing coverage. Please review.

Project coverage is 61.56%. Comparing base (c14278e) to head (926ccc4).
Report is 16 commits behind head on devel.

Files with missing lines Patch % Lines
src/radical/utils/zmq/client.py 87.50% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##            devel     #423      +/-   ##
==========================================
+ Coverage   61.54%   61.56%   +0.01%     
==========================================
  Files          62       62              
  Lines        6967     6972       +5     
==========================================
+ Hits         4288     4292       +4     
- Misses       2679     2680       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@mtitov mtitov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@andre-merzky andre-merzky merged commit 0cb6d17 into devel Oct 25, 2024
11 checks passed
@andre-merzky andre-merzky deleted the fix/client_log branch October 25, 2024 03:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants