Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/flux remote #408

Merged
merged 3 commits into from
May 31, 2024
Merged

Fix/flux remote #408

merged 3 commits into from
May 31, 2024

Conversation

andre-merzky
Copy link
Member

No description provided.

Copy link

codecov bot commented May 28, 2024

Codecov Report

Attention: Patch coverage is 0% with 10 lines in your changes missing coverage. Please review.

Project coverage is 62.04%. Comparing base (52964c6) to head (dff7984).
Report is 56 commits behind head on devel.

Files with missing lines Patch % Lines
src/radical/utils/flux.py 0.00% 10 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##            devel     #408      +/-   ##
==========================================
- Coverage   62.09%   62.04%   -0.06%     
==========================================
  Files          62       62              
  Lines        6830     6834       +4     
==========================================
- Hits         4241     4240       -1     
- Misses       2589     2594       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@mtitov mtitov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! couple comments regarding debug messages

src/radical/utils/flux.py Outdated Show resolved Hide resolved
src/radical/utils/flux.py Outdated Show resolved Hide resolved
@andre-merzky andre-merzky merged commit ff705fc into devel May 31, 2024
7 of 8 checks passed
@andre-merzky andre-merzky deleted the fix/flux_remote branch May 31, 2024 08:06
@mtitov mtitov added the external label Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants