Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

simplify deployment #404

Merged
merged 31 commits into from
May 7, 2024
Merged

simplify deployment #404

merged 31 commits into from
May 7, 2024

Conversation

andre-merzky
Copy link
Member

Cleaner deployment and versioning, prompted by setuptools upgrade.

@andre-merzky andre-merzky requested a review from mtitov April 22, 2024 13:24
@andre-merzky andre-merzky self-assigned this Apr 22, 2024
@mturilli mturilli requested review from mturilli and removed request for mtitov April 26, 2024 15:23
@andre-merzky andre-merzky enabled auto-merge April 29, 2024 23:27
@mtitov mtitov mentioned this pull request Apr 30, 2024
Merged
@andre-merzky andre-merzky requested a review from mtitov April 30, 2024 06:34
@codecov Codecov
Copy link

codecov bot commented Apr 30, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 56.09756% with 18 lines in your changes missing coverage. Please review.

Project coverage is 61.81%. Comparing base (2445ad6) to head (8c53239).
Report is 116 commits behind head on devel.

Files with missing lines Patch % Lines
src/radical/utils/heartbeat.py 0.00% 15 Missing ⚠️
src/radical/utils/get_version.py 85.71% 2 Missing ⚠️
src/radical/utils/stack.py 87.50% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##            devel     #404      +/-   ##
==========================================
- Coverage   62.46%   61.81%   -0.66%     
==========================================
  Files          62       61       -1     
  Lines        6818     6764      -54     
==========================================
- Hits         4259     4181      -78     
- Misses       2559     2583      +24

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mtitov

This comment was marked as resolved.

Sign in to view
mturilli
mturilli reviewed Apr 30, 2024
View reviewed changes
tests/unittests/test_json.py Outdated

# ------------------------------------------------------------------------------
#
def test_metric_expand():
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are we dropping this test?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because the method which was tested here got removed.

@andre-merzky

This comment was marked as resolved.

Sign in to view
@andre-merzky
Copy link
Member Author

@mtitov , @mturilli : this should be ready now.

@mtitov

This comment was marked as resolved.

Sign in to view
mtitov
mtitov reviewed May 2, 2024
View reviewed changes
setup.py Outdated Show resolved Hide resolved
src/radical/utils/get_version.py Outdated Show resolved Hide resolved
src/radical/utils/get_version.py Outdated Show resolved Hide resolved
@andre-merzky
Copy link
Member Author

I rewrote this now. Instead of creating version detail and parsing again, setup.py now stores the individual pieces in VERSION and get_version() get's them unaltered. This is simpler, less error prone and makes fewer assumptions about tag structure etc.

@andre-merzky andre-merzky requested a review from mtitov May 2, 2024 21:27
@andre-merzky andre-merzky assigned mtitov and mturilli and unassigned mtitov and mturilli May 3, 2024
mtitov

This comment was marked as resolved.

Sign in to view

@andre-merzky andre-merzky requested a review from mtitov May 7, 2024 20:45
@andre-merzky
Copy link
Member Author

Thanks @mtitov, I iterated the PR as suggested.

mtitov
mtitov approved these changes May 7, 2024
View reviewed changes
Copy link
Collaborator

@mtitov mtitov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!!

@andre-merzky andre-merzky merged commit c3e5178 into devel May 7, 2024
9 checks passed
@andre-merzky andre-merzky deleted the feature/deployment branch May 7, 2024 22:28
@andre-merzky andre-merzky restored the feature/deployment branch May 7, 2024 22:28
@mtitov mtitov added the internal label Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtitov mtitov mtitov approved these changes

@mturilli mturilli Awaiting requested review from mturilli

Assignees

@andre-merzky andre-merzky

Labels
internal priority:medium topic:deployment type:enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andre-merzky @mtitov @mturilli