Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add flux module path #400

Merged
merged 1 commit into from
Mar 18, 2024
Merged

add flux module path #400

merged 1 commit into from
Mar 18, 2024

Conversation

andre-merzky
Copy link
Member

Copy link

codecov bot commented Mar 16, 2024

Codecov Report

Attention: Patch coverage is 10.52632% with 17 lines in your changes missing coverage. Please review.

Project coverage is 62.22%. Comparing base (397654d) to head (dc4f38f).
Report is 197 commits behind head on devel.

Files with missing lines Patch % Lines
src/radical/utils/flux.py 6.66% 14 Missing ⚠️
src/radical/utils/debug.py 25.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##            devel     #400      +/-   ##
==========================================
- Coverage   62.37%   62.22%   -0.15%     
==========================================
  Files          61       61              
  Lines        6758     6775      +17     
==========================================
+ Hits         4215     4216       +1     
- Misses       2543     2559      +16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@mtitov mtitov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

p.s. tested it without setting PYTHONPATH on my side, python flux was discovered correctly

@andre-merzky andre-merzky merged commit 8c3f6c9 into devel Mar 18, 2024
5 checks passed
@andre-merzky andre-merzky deleted the fix/issue_rp_3149 branch March 18, 2024 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flux LM to auto-set PYTHONPATH
2 participants