Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

avoid file collissions #392

Merged
merged 9 commits into from
Oct 25, 2023
Merged

avoid file collissions #392

merged 9 commits into from
Oct 25, 2023

Conversation

andre-merzky
Copy link
Member

This is related to RP issue 3055 - the PR attempts to avoid similar file name collisions.

@codecov
Copy link

codecov bot commented Oct 7, 2023

Codecov Report

Attention: Patch coverage is 73.33333% with 4 lines in your changes missing coverage. Please review.

Project coverage is 61.69%. Comparing base (5ff85db) to head (e5e7a6e).
Report is 240 commits behind head on devel.

Files with missing lines Patch % Lines
src/radical/utils/config.py 73.33% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##            devel     #392      +/-   ##
==========================================
+ Coverage   61.60%   61.69%   +0.08%     
==========================================
  Files          61       61              
  Lines        6832     6837       +5     
==========================================
+ Hits         4209     4218       +9     
+ Misses       2623     2619       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

src/radical/utils/config.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@mtitov mtitov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andre-merzky if you agree with changes, it is ready for merging

@andre-merzky
Copy link
Member Author

@mtitov - thanks for completing this!

@andre-merzky andre-merzky merged commit d88410e into devel Oct 25, 2023
4 checks passed
@andre-merzky andre-merzky deleted the fix/issue_rp_3055 branch October 25, 2023 13:29
@mtitov mtitov added the internal label Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants