Hotfix/srun cancellation #3293
Open
Hotfix/srun cancellation #3293
+271
−142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## devel #3293 +/- ##
==========================================
- Coverage 42.91% 42.79% -0.12%
==========================================
Files 97 97
Lines 11286 11351 +65
==========================================
+ Hits 4843 4858 +15
- Misses 6443 6493 +50 ☔ View full report in Codecov by Sentry. |
mtitov
reviewed
Dec 19, 2024
|
|
||
| # -------------------------------------------------------------------------- | ||
| # | ||
| def cancel_task(self, task): |
There was a problem hiding this comment.
something wrong with states update - tmgr has the following states for cancelled tasks
state: "FAILED"
target_state: "CANCELED"
There was a problem hiding this comment.
$ cat agent_staging_output.0000.log | grep "m0.i0.s9.hello.2.0000"
1734567093.938 : agent_staging_output.0000 : 47102 : 140624563013184 : DEBUG : task m0.i0.s9.hello.2.0000 skips staging: FAILED
1734567094.000 : agent_staging_output.0000 : 47102 : 140624563013184 : DEBUG : task m0.i0.s9.hello.2.0000 skips staging: CANCELED
appears two times in staging output
There was a problem hiding this comment.
the following fix 6449329 helped to overcome the issue (it is within the project/impeccable branch)
mtitov
reviewed
Dec 19, 2024
Comment on lines
+104
to
+105
| time.sleep(0.1) | ||
| os.killpg(pid, signal.SIGINT) |
There was a problem hiding this comment.
import os
import signal
import time
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.