Hotfix/mkdir #3165
Merged
Hotfix/mkdir #3165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mturilli
reviewed
Apr 10, 2024
| if action != rpc.TRANSFER: | ||
| tgtdir = os.path.dirname(tgt.path) | ||
| if tgtdir != task_sandbox.path: | ||
| self._log.debug("mkdir %s", tgtdir) |
There was a problem hiding this comment.
Should we elevate this to a warning with something like: "WARNING: implicit directory creation! Mkdir %s"?
There was a problem hiding this comment.
I don't think this would help: unless the end user is actively looking for warnings in the agent logs, it would not really show up. Also, if we provide some semantics then users begin to rely on it (as we have just seen in this case), and then a warning is not intuitive either.
Having said that, I will open a ticket to clearly document the implemented behavior - sorry for not doing that anyway...
There was a problem hiding this comment.
#3166 is now open for this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another hotfix for staging semantics to get FACTS unstuck.