expand raptor example #3121
Merged
expand raptor example #3121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
now terminates on worker failures
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## devel #3121 +/- ##
==========================================
+ Coverage 44.51% 44.53% +0.02%
==========================================
Files 96 96
Lines 10543 10542 -1
==========================================
+ Hits 4693 4695 +2
+ Misses 5850 5847 -3 ☔ View full report in Codecov by Sentry. |
|
ping @AymenFJA : can you please review the PR independent of applying this in Parsl? |
AymenFJA
reviewed
Feb 1, 2024
src/radical/pilot/session.py
Outdated
| @@ -175,6 +175,7 @@ def __init__(self, proxy_url: Optional[str ] = None, | |||
| self._tmgrs = dict() # map IDs to tmgr instances | |||
| self._cmgr = None # only primary sessions have a cmgr | |||
| self._rm = None # resource manager (agent_0 sessions) | |||
| self._hb = None # heartbeat monitor | |||
|
|
|||
| # this session is either living in the client applicatio or lives in the | |||
There was a problem hiding this comment.
Typo here: applicatio --> application
AymenFJA
approved these changes
Feb 1, 2024
There was a problem hiding this comment.
@andre-merzky I left one small comment. Other than that I think it looks good. Thanks.
…bertools/radical.pilot into fix/raptor_worker_termination
|
Thanks @AymenFJA |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
now terminates on worker failures