Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed type for LFS_SIZE_PER_NODE #3118

Merged
merged 1 commit into from
Jan 17, 2024
Merged

Conversation

mtitov
Copy link
Contributor

@mtitov mtitov commented Jan 16, 2024

caused this issue (RCT stack 1.46.0)

(ve) [[email protected] pilot.0000]$ cat agent_0.err
Traceback (most recent call last):
  File "/lustre/orion/chm155/scratch/matitov/st1/ve/bin/radical-pilot-agent_0", line 17, in <module>
    agent = rp.Agent_0()
  File "/lustre/orion/chm155/scratch/matitov/st1/ve/lib/python3.9/site-packages/radical/pilot/agent/agent_0.py", line 47, in __init__
    self._session = Session(uid=cfg.sid, cfg=cfg, _role=Session._AGENT_0)
  File "/lustre/orion/chm155/scratch/matitov/st1/ve/lib/python3.9/site-packages/radical/pilot/session.py", line 191, in __init__
    elif self._role == self._AGENT_0: self._init_agent_0()
  File "/lustre/orion/chm155/scratch/matitov/st1/ve/lib/python3.9/site-packages/radical/pilot/session.py", line 287, in _init_agent_0
    self._init_rm()
  File "/lustre/orion/chm155/scratch/matitov/st1/ve/lib/python3.9/site-packages/radical/pilot/session.py", line 808, in _init_rm
    self._rm = ResourceManager.create(name=rname,
  File "/lustre/orion/chm155/scratch/matitov/st1/ve/lib/python3.9/site-packages/radical/pilot/agent/resource_manager/base.py", line 382, in create
    return rm(cfg, rcfg, log, prof)
  File "/lustre/orion/chm155/scratch/matitov/st1/ve/lib/python3.9/site-packages/radical/pilot/agent/resource_manager/base.py", line 152, in __init__
    rm_info.verify()
  File "/lustre/orion/chm155/scratch/matitov/st1/ve/lib/python3.9/site-packages/radical/utils/typeddict.py", line 416, in verify
    self._data[k] = self._verify_kvt(k, v, self._schema[k])
  File "/lustre/orion/chm155/scratch/matitov/st1/ve/lib/python3.9/site-packages/radical/utils/typeddict.py", line 396, in _verify_kvt
    if t in [str, int, float]  : return cls._verify_base(k, v, t)
  File "/lustre/orion/chm155/scratch/matitov/st1/ve/lib/python3.9/site-packages/radical/utils/typeddict.py", line 333, in _verify_base
    cls.__raise_type_error(k, v, t)
  File "/lustre/orion/chm155/scratch/matitov/st1/ve/lib/python3.9/site-packages/radical/utils/typeddict.py", line 322, in __raise_type_error
    raise TDTypeError(
radical.utils.typeddict.TDTypeError: RMInfo.verify - attribute "lfs_per_node" - expected type <class 'int'>, got <class 'str'>

Copy link

codecov bot commented Jan 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (dfe20f5) 44.50% compared to head (404de41) 44.50%.

Additional details and impacted files
@@           Coverage Diff           @@
##            devel    #3118   +/-   ##
=======================================
  Coverage   44.50%   44.50%           
=======================================
  Files          96       96           
  Lines       10545    10545           
=======================================
  Hits         4693     4693           
  Misses       5852     5852           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@andre-merzky andre-merzky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense!

@mtitov
Copy link
Contributor Author

mtitov commented Jan 16, 2024

@andre-merzky should this be merged into master branch and released with 1.46.1?

@andre-merzky andre-merzky merged commit 4271319 into devel Jan 17, 2024
30 checks passed
@andre-merzky andre-merzky deleted the hotfix/resource_config branch January 17, 2024 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants