Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix flux event management #3102

Merged
merged 12 commits into from
Jan 12, 2024
Merged

fix flux event management #3102

merged 12 commits into from
Jan 12, 2024

Conversation

andre-merzky
Copy link
Member

@andre-merzky andre-merzky commented Dec 7, 2023

This fixes #2837

Copy link

codecov bot commented Dec 7, 2023

Codecov Report

Attention: 47 lines in your changes are missing coverage. Please review.

Comparison is base (7e72843) 44.22% compared to head (fd91244) 44.50%.

Files Patch % Lines
src/radical/pilot/agent/executing/flux.py 8.82% 31 Missing ⚠️
src/radical/pilot/agent/scheduler/flux.py 0.00% 14 Missing ⚠️
src/radical/pilot/utils/component.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##            devel    #3102      +/-   ##
==========================================
+ Coverage   44.22%   44.50%   +0.27%     
==========================================
  Files          96       96              
  Lines       10615    10545      -70     
==========================================
- Hits         4695     4693       -2     
+ Misses       5920     5852      -68     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mtitov
Copy link
Contributor

mtitov commented Jan 9, 2024

need to update requirements.txt -> radical.utils>=1.44 (and update saga as well -> >=1.40)

@andre-merzky
Copy link
Member Author

need to update requirements.txt -> radical.utils>=1.44 (and update saga as well -> >=1.40)

Thanks, done

@andre-merzky
Copy link
Member Author

The tests now fail for the missing radical.utils>=1.44 dependency - will get fixed once that is released.

@andre-merzky
Copy link
Member Author

Tests are passing now...

Copy link
Contributor

@mtitov mtitov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@andre-merzky andre-merzky merged commit dfe20f5 into devel Jan 12, 2024
30 checks passed
@andre-merzky andre-merzky deleted the fix/flux branch January 12, 2024 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error in Flux LM initialization
2 participants