Merge pull request #3289 from radical-cybertools/fix/task_target_state

target state is interpreted *after* output staging
radical-cybertools · Dec 16, 2024 · 2618c57 · 2618c57
2 parents 1eb596c + 70c6bc6
commit 2618c57
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 2 deletions.
diff --git a/src/radical/pilot/task_manager.py b/src/radical/pilot/task_manager.py
@@ -385,8 +385,8 @@ def _update_tasks(self, task_dicts):
                 current = task.state
                 target  = task_dict['state']
 
-                if 'target_state' in task_dict:
-                    target = task_dict['target_state']
+              # if 'target_state' in task_dict:
+              #     target = task_dict['target_state']
 
                 if current == target:
                     self._log.debug('tmgr: state known: %s', uid)

diff --git a/src/radical/pilot/tmgr/staging_output/default.py b/src/radical/pilot/tmgr/staging_output/default.py
@@ -67,6 +67,13 @@ def work(self, tasks):
 
         for task in tasks:
 
+            # we only handle staging for tasks which end up in `DONE` state
+            target_state = task.get('target_state')
+            if target_state and target_state != rps.DONE:
+                self._log.debug('skip staging for %s', task['uid'])
+                no_staging_tasks.append(task)
+                continue
+
             # check if we have any staging directives to be enacted in this
             # component
             actionables = list()