Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ensure that failed tasks fail the workload - if so configured #670

Merged
merged 5 commits into from
Aug 12, 2024

Conversation

andre-merzky
Copy link
Member

This fixes #669

Copy link

codecov bot commented Aug 2, 2024

Codecov Report

Attention: Patch coverage is 52.38095% with 10 lines in your changes missing coverage. Please review.

Project coverage is 71.43%. Comparing base (b001af2) to head (edf205e).

Files Patch % Lines
src/radical/entk/execman/rp/task_manager.py 0.00% 5 Missing ⚠️
src/radical/entk/appman/wfprocessor.py 75.00% 3 Missing ⚠️
src/radical/entk/appman/appmanager.py 50.00% 1 Missing ⚠️
src/radical/entk/execman/rp/task_processor.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##            devel     #670      +/-   ##
==========================================
- Coverage   71.68%   71.43%   -0.25%     
==========================================
  Files          26       26              
  Lines        2313     2321       +8     
==========================================
  Hits         1658     1658              
- Misses        655      663       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@mtitov mtitov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mtitov mtitov merged commit 2ccf82f into devel Aug 12, 2024
4 checks passed
@mtitov mtitov deleted the fix/task_failures branch August 12, 2024 04:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

task failures are not popping up
2 participants