Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scala 2.12 with Spark 2.4.4 and Hadoop 2.8.5 #298

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

toxicafunk
Copy link

Scala build for Scala 2.12, Spark 2.4.4 and Hadoop 2.8.5. It uses the s2i-scala-container for Scala 2.12 from this PR.

Some weird issue I encountered in assemble scripts were:

  1. for conf_file in *; do returned a String with all the file names of a dir, I had to replace it with for conf_file in $(ls); do
  2. Similarly, for assemble in $(ls -1 $STI_SCRIPTS_PATH | grep -w "^[0-9]*-*"); do just looped forever so I just hardcoded the call.

@todo
Copy link

todo bot commented Apr 28, 2021

we can add a shortcut error here by testing

oshinko-s2i/rad-image

Lines 516 to 521 in 44a22e5

# TODO we can add a shortcut error here by testing
# for existence of the build input if the value is
# not a schema
if [ "$localbuild" == "false" ]; then
check_oc_login


This comment was generated by todo based on a TODO comment in 44a22e5 in #298. cc @toxicafunk.

@rimolive
Copy link
Member

Hi @toxicafunk. Thank you so much for the contribution! I'm reviewing the PR and soon will be merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants