Fix builds on Windows by forcing Unix style EndOfLines on the repo #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix by using the [per repository .gitattributes overrides](https://help.github.com/articles/dealing-with-line-endings/#per-repository-settings) Rationale: The Windows' default is 'auto', which will result in checking out CRLF and, as a result, eslint and parser tests complaining. None of them can be made dynamic, so this is the only real option. Windows editors support Unix EOLs just fine, so this should really be OK. The worst that can happen is someone that didn't run tests commits Windows EOLs in his fork, which will get caught by the eslint and tests checks on the pull requests.
This was referenced Jun 20, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix by using the per repository .gitattributes overrides
Rationale: The Windows' default is 'auto', which will result in checking out CRLF and, as a result, eslint and parser tests complaining. None of them can be made dynamic, so this is the only real option.
Windows editors support Unix EOLs just fine, so this should really be OK. The worst that can happen is someone that didn't run tests commits Windows EOLs in his fork, which will get caught by the eslint and tests checks on the pull requests.