Fix #64 FP on rule unused-variable: Variable in doc string not recogn…

…ized

gherkin-checks/src/main/java/org/sonar/gherkin/checks/UnusedVariableCheck.java

@@ -71,7 +71,6 @@ private void checkUnusedDataTableColumn(ExamplesTree examples, Set<String> allVa
         "Remove the following unused variable" + (unusedVariables.size() > 1 ? "s" : "") + ": "
           + unusedVariables.stream().sorted().collect(Collectors.joining(", ")));
     }
-
   }
 
 }

gherkin-checks/src/test/resources/checks/unused-variable.feature

@@ -93,3 +93,26 @@ Feature: My feature Unused variable
       | number |
       | 1      |
       | 2      |
+
+Scenario Outline: Scenario 6 Unused variable
+    Given Blabla given...
+      """
+      Blabla...
+      Blabla... <number> blabla...
+      """
+    When Blabla when...
+    Then Blabla then...
+    # Noncompliant [[sc=5;ec=13]] {{Remove the following unused variable: type}}
+    Examples:
+      | number | type |
+      | 1      | bike |
+      | 2      | book |
+    # Noncompliant [[sc=5;ec=13]] {{Remove the following unused variable: bbbb}}
+    Examples:
+      | number | bbbb |
+      | 1      | bike |
+      | 2      | book |
+    Examples:
+      | number |
+      | 1      |
+      | 2      |

gherkin-frontend/src/main/java/org/sonar/gherkin/tree/impl/StepTreeImpl.java

@@ -118,6 +118,10 @@ private void initVariables() {
     if (table != null) {
       table.rows().stream().map(SyntaxToken::text).forEach(this::addVariablesFromText);
     }
+
+    if (docString != null) {
+      docString.data().stream().map(SyntaxToken::text).forEach(this::addVariablesFromText);
+    }
   }
 
   private void addVariablesFromText(String text) {

gherkin-frontend/src/test/java/org/sonar/gherkin/parser/StepTreeTest.java

@@ -82,6 +82,17 @@ public void step() throws Exception {
     assertThat(tree.variables().contains("ghi")).isTrue();
     assertThat(tree.variables().contains("zzz")).isFalse();
 
+    tree = checkParsed("Given blabla...\n" +
+        "  \"\"\"\n" +
+        "  {\n" +
+        "    \"code\":\"79365\",\n" +
+        "    \"price\":<value>\n" +
+        "  }\n" +
+        "  \"\"\"",
+      "Given ", "blabla...");
+    assertThat(tree.variables()).hasSize(1);
+    assertThat(tree.variables().contains("value")).isTrue();
+
     checkParsed("Given  I am a customer", "Given ", " I am a customer");
   }
 

its/ruling/projects/custom/unused-variable.feature

@@ -93,3 +93,26 @@ Feature: My feature Unused variable
       | number |
       | 1      |
       | 2      |
+
+  Scenario Outline: Scenario 6 Unused variable
+    Given Blabla given...
+      """
+      Blabla...
+      Blabla... <number> blabla...
+      """
+    When Blabla when...
+    Then Blabla then...
+      # Noncompliant [[sc=5;ec=13]] {{Remove the following unused variable: type}}
+    Examples:
+      | number | type |
+      | 1      | bike |
+      | 2      | book |
+      # Noncompliant [[sc=5;ec=13]] {{Remove the following unused variable: bbbb}}
+    Examples:
+      | number | bbbb |
+      | 1      | bike |
+      | 2      | book |
+    Examples:
+      | number |
+      | 1      |
+      | 2      |

its/ruling/tests/src/test/expected/gherkin-unused-variable.json

@@ -8,5 +8,7 @@
 49,
 83,
 88,
+106,
+111,
 ],
 }