Automated Resyntax fixes #703
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![resyntax-ci[bot]](https://avatars.githubusercontent.com/in/999945?s=60&v=4){kind=small}
Keep imports in `require` sorted and grouped by phase, with collections before files.
This `if` expression can be refactored to an equivalent expression using `and`.
The `define` form supports a shorthand for defining functions.
Internal definitions are recommended instead of `let` expressions, to reduce nesting.
Internal definitions are recommended instead of `let` expressions, to reduce nesting.
…ut-lambda` The lambda can be removed from the failure result in this `hash-ref` expression.
This negated `when` expression can be replaced by an `unless` expression.
Internal definitions are recommended instead of `let` expressions, to reduce nesting.
Internal definitions are recommended instead of `let` expressions, to reduce nesting.
This negated `when` expression can be replaced by an `unless` expression.
rfindler
reviewed
Dec 22, 2024
| default])))) | ||
| (define (filename->defs source [default #f]) | ||
| (let/ec | ||
| k |
There was a problem hiding this comment.
@sorawee this is an unfortunate newline, I'd say. Better if let/ec always put the identifier on the same line and then to inside the let/ec isntead of to the start of the identifier. Is that possible?
There was a problem hiding this comment.
I agree. Currently the let/ec call is treated like a function application. It would be easy to instruct that it's a special form, which needs to be formatted differently.
There was a problem hiding this comment.
Fixed by sorawee/fmt#83. @jackfirth is there a way to re-run this PR with the latest fmt?
|
This looks good to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resyntax fixed 20 issues in 1 file.
let-to-defineinverted-whendefine-lambda-to-definecond-let-to-cond-definehash-ref-with-constant-lambda-to-hash-ref-without-lambdaif-else-false-to-andtidy-require