Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: adds github workflow to create an ironic esp image #450

Merged
merged 1 commit into from
Nov 8, 2024
Merged

feat: adds github workflow to create an ironic esp image #450

merged 1 commit into from
Nov 8, 2024

Conversation

nicholaskuechler
Copy link
Contributor

@nicholaskuechler nicholaskuechler commented Nov 7, 2024 •
edited
Loading

cardoe
cardoe requested changes Nov 7, 2024
View reviewed changes
Copy link
Contributor

@cardoe cardoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add this to the regular images workflow so it's all released together.

@nicholaskuechler nicholaskuechler force-pushed the PUC-652-20241107-1 branch 20 times, most recently from 4673d5e to 8752040 Compare November 7, 2024 20:54
@nicholaskuechler nicholaskuechler marked this pull request as ready for review November 7, 2024 21:42
cardoe
cardoe approved these changes Nov 8, 2024
View reviewed changes
Copy link
Contributor

@cardoe cardoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So this proves what I was saying on the original change here that the release needs to be in a final step as one upload.

@cardoe cardoe added this pull request to the merge queue Nov 8, 2024
Merged via the queue into main with commit 2e1fe24 Nov 8, 2024
19 checks passed
@cardoe cardoe deleted the PUC-652-20241107-1 branch November 8, 2024 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cardoe cardoe cardoe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nicholaskuechler @cardoe