ci: enable code coverage reporting on neutron-understack #253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skrobul
added a commit
that referenced
this pull request
Sep 9, 2024
This reverts commits 952f8c3 and 27f5b2f. These changes have already been implemented in: #251 #253 Both of the PRs solve the same problem, so I don't need to solve it here again. It was initially fixed only because I was not aware of the other PRs. Reverting instead of dropping these commits, because they have been referenced externally in the comments.
skrobul
added a commit
that referenced
this pull request
Sep 9, 2024
This reverts commits 3f0e9f8 and b4961f4 These changes have already been implemented in: #251 #253 Both of the PRs solve the same problem, so I don't need to solve it here again. It was initially fixed only because I was not aware of the other PRs. Reverting instead of dropping these commits, because they have been referenced externally in the comments.
skrobul
added a commit
that referenced
this pull request
Sep 9, 2024
This reverts commits 664312d8e1828e5608671b0b2853f8c62ba0e165 and a7819cf These changes have already been implemented in: #251 #253 Both of the PRs solve the same problem, so I don't need to solve it here again. It was initially fixed only because I was not aware of the other PRs. Reverting instead of dropping these commits, because they have been referenced externally in the comments.
Trigger these jobs on any change in the python/ path. De-dupped the rules to avoid bad copy and paste in the paths, specifically around the coverage which had checked the ironic code coverage instead.
cardoe
force-pushed
the
neutron-pytest
branch
from
d866490 to
d74f0a7
Compare
cardoe
changed the title
skrobul
approved these changes
Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable code coverage reporting on neutron-understack and de-dup the rules.