New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: consolidate workflows into understack_workflows #199

Merged

cardoe merged 2 commits into main from wf-common-image

Aug 7, 2024

Collaborator

skrobul commented Aug 6, 2024

This PR moves:

nautobot-update-cf
ironic-to-nautobot-sync
undersync-device

workflows into the shared ironic-nautobot-client container image/python package.

Closes https://rackspace.atlassian.net/browse/PUC-421

skrobul force-pushed the wf-common-image branch from 1e3e239 to eb7614f Compare

August 6, 2024 11:32

skrobul requested a review from a team

August 6, 2024 17:44

skrobul force-pushed the wf-common-image branch 2 times, most recently from c0595ec to d4fa2f2 Compare

August 6, 2024 18:44

github-actions bot commented Aug 6, 2024 •

edited

Loading

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines	Covered	Coverage	Threshold	Status
771	239	31%	0%	🟢

New Files

No new covered files...

Modified Files

No covered modified files...

updated for commit: 8383436 by action🐍

cardoe force-pushed the wf-common-image branch from d4fa2f2 to a88aa04 Compare

August 6, 2024 20:23

cardoe reviewed

View reviewed changes

python/understack-workflows/understack_workflows/main/nautobot_update_cf.py Outdated Show resolved Hide resolved

cardoe reviewed

View reviewed changes

python/understack-workflows/understack_workflows/main/undersync_device.py Outdated Show resolved Hide resolved

cardoe reviewed

View reviewed changes

python/understack-workflows/understack_workflows/main/undersync_device.py Show resolved Hide resolved

cardoe reviewed

View reviewed changes

python/understack-workflows/understack_workflows/main/undersync_device.py Show resolved Hide resolved

cardoe reviewed

View reviewed changes

python/understack-workflows/understack_workflows/nautobot.py Outdated Show resolved Hide resolved

cardoe reviewed

View reviewed changes

python/understack-workflows/understack_workflows/nautobot.py Outdated Show resolved Hide resolved

cardoe reviewed

View reviewed changes

python/understack-workflows/understack_workflows/nautobot.py Outdated Show resolved Hide resolved

cardoe reviewed

View reviewed changes

python/understack-workflows/understack_workflows/nautobot.py Outdated Show resolved Hide resolved

cardoe reviewed

View reviewed changes

python/understack-workflows/understack_workflows/nautobot.py Outdated Show resolved Hide resolved

cardoe reviewed

View reviewed changes

python/understack-workflows/understack_workflows/main/undersync_device.py Outdated Show resolved Hide resolved

cardoe reviewed

View reviewed changes

Contributor

cardoe left a comment

Well I rebased it so hopefully that doesn't mess ya up but left some comments on some clean ups.

skrobul force-pushed the wf-common-image branch 3 times, most recently from 2a9ac86 to 5d3b935 Compare

August 7, 2024 14:54

skrobul added 2 commits

August 7, 2024 15:56


          extract undersync-device workflow into understack_workflows

4d79aa9


          extract nautobot-update-cf workflow into understack_workflows

skrobul force-pushed the wf-common-image branch from 5d3b935 to 8383436 Compare

August 7, 2024 14:56

skrobul requested a review from cardoe

August 7, 2024 14:58

cardoe approved these changes

View reviewed changes

cardoe merged commit 14d669d into main

13 checks passed

cardoe deleted the wf-common-image branch

August 7, 2024 15:15

skrobul mentioned this pull request

fix: undersync-device: fix argument name #205

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet