feat: refactor ironic node create/update and setting of interfaces #194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
python/understack-workflows/understack_workflows/main/synchronize_obm_creds.py
Outdated
Show resolved
Hide resolved
Added a common from argo event parser for the IronicNodeConfiguration class and create tests with a sample event. Utilize this event parser to create the node in ironic. The code follows the python-ironicclient a little bit more closely here.
If we're working with an iDRAC based interface then we need to use the Ironic idrac driver, otherwise use the redfish based driver. this integrates some of the behaviors of #168. The communication with Nautobot is going to ultimately be the best approach. But the configuration of the Ironic side is better in this code.
When our nodes are in the manage state, we need to update their data as well since we'll only be bringing nodes back to the manage state to make changes to them.
Set the BMC username and password using the helper function from ironicclient instead of having our own.
Drop another function local to the obm function and use the shared copy.
nicholaskuechler
approved these changes
Aug 5, 2024
skrobul
approved these changes
Aug 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored the create/update of the ironic node from the Nautobot data. Include code to adjust how we ensure that the driver and interfaces are set correctly. This partially grows out of #168 but doesn't include the full driver detection from Nautobot.