work around poor interaction between whatever changed in zope.interface 4.3.3's usage of namespace packages and py2app #701
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and sometimes the namespace package gets you
glyph
changed the title
Current coverage is 99.60% (diff: 100%)@@ master #701 diff @@
==========================================
Files 79 79
Lines 5564 5564
Methods 0 0
Messages 0 0
Branches 785 785
==========================================
Hits 5542 5542
Misses 10 10
Partials 12 12
|
derwolfe
approved these changes
Dec 14, 2016
| @@ -24,6 +24,10 @@ pip install .; | |||
| # install dependencies that are needed to build and run the mac application | |||
| pip install -r requirements/mac-app.txt; | |||
|
|
|||
| # work around zope.interface's namespace module shenanigans | |||
| # see https://github.com/zopefoundation/zope.interface/issues/67 | |||
There was a problem hiding this comment.
@glyph Should we track a todo to remove this with a mimic issue linked to zopefoundation/zope.interface#67?
There was a problem hiding this comment.
Opened #702 to track this work.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow #700 to land
zopefoundation/zope.interface#67