When using multi statem call only retry for certain errors. #433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of trying all server ids in the supplied list whenever an
error or timeout was encountered this change only retries when
certain errors such as noproc, nodedown etc is encountered.
If all errors result in a retry genuine API errors such as
{error, not_member} in reposnse to a ra:remove_member/2 interaction
would be hidden in the aggregate error that is returned once
all members have returned.
the-mikedavis
approved these changes
Apr 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of trying all server ids in the supplied list whenever an error or timeout was encountered this change only retries when certain errors such as noproc, nodedown etc is encountered.
If all errors result in a retry genuine API errors such as
{error, not_member}in response to ara:remove_member/2interaction would be hidden in the aggregate error that is returned once all members have returned.Related: rabbitmq/rabbitmq-server#11029