Implement new log effects type: log_ext that only reads any entries…

… that

exists in the mem table and returns an opaque "read plan" that can be
executed by any process on the same node by using the `ra_log_read_plan:execute/2`
function.

This PR also refactors follower effect filtering to be done in the ra_server_proc
only in order to keep this logic in one place.

Other minor refactorings and fixes and some improvements to effect documentation.

README.md

@@ -440,14 +440,17 @@ logger:set_primary_config(level, debug).
 Ra attempts to follow [Semantic Versioning](https://semver.org/).
 
 The modules that form part of the public API are:
+
 * `ra`
 * `ra_machine` (behaviour callbacks only)
 * `ra_aux`
 * `ra_system`
-* `ra_counters`
+* `ra_counters` (counter keys may vary between minors)
 * `ra_leaderboard`
 * `ra_env`
 * `ra_directory`
+* `ra_flru`
+* `ra_log_read_plan`
 
 ## Copyright and License
 

docs/internals/STATE_MACHINE_TUTORIAL.md

@@ -181,6 +181,23 @@ Only the leader that first applies an entry will attempt the effect.
 Followers process the same set of commands but simply throw away any effects
 returned by the state machine unless specific effect provide the `local` option.
 
+### Machine Effects table
+
+| Spec | Executed on |
+| -----| ----------- |
+| `{send_msg, pid(), Msg :: term()}` | leader |
+| `{send_msg, pid(), Msg :: term(), [local]}` | on member local to `pid()` else leader |
+| `{monitor \| demonitor, process \| node, pid() \| node()}` | leader |
+| `{mod_call, mfa()}` | leader |
+| `{timer, Name :: term(), Time :: non_neg_integer() \| infinity}` | leader |
+| `{append, term()}` | leader |
+| `{append, term(), ra_server:command_reply_mode()}` | leader |
+| `{log, [ra_index()], fun(([user_command()]) -> effects())}` | leader |
+| `{log, [ra_index()], fun(([user_command()]) -> effects()), {local, node()}}` | on member local to `node()` else leader |
+| `{log_ext, [ra_index()], fun(([ra_log:read_plan()]) -> effects()), {local, node()}}` | on member local to `node()` else leader |
+| `{release_cursor \| checkpoint, ra_index(), term()}` | all members |
+| `{aux, term()}` | every member |
+
 
 ### Send a message
 

src/ra.erl

@@ -1262,7 +1262,6 @@ key_metrics({Name, N} = ServerId, _Timeout) when N == node() ->
 key_metrics({_, N} = ServerId, Timeout) ->
     erpc:call(N, ?MODULE, ?FUNCTION_NAME, [ServerId], Timeout).
 
-
 %% internal
 
 -spec usr(UserCommand, ReplyMode) -> Command when

src/ra_lib.erl

@@ -49,7 +49,8 @@
          is_dir/1,
          is_file/1,
          ensure_dir/1,
-         consult/1
+         consult/1,
+         cons/2
         ]).
 
 -type file_err() :: file:posix() | badarg | terminated | system_limit.
@@ -454,6 +455,10 @@ consult(Path) ->
             Err
     end.
 
+cons(Item, List)
+  when is_list(List) ->
+    [Item | List].
+
 tokens(Str) ->
     case erl_scan:string(Str) of
         {ok, Tokens, _EndLoc} ->

src/ra_log.erl

@@ -20,6 +20,9 @@
          write_sync/2,
          fold/5,
          sparse_read/2,
+         partial_read/3,
+         execute_read_plan/3,
+         read_plan_info/1,
          last_index_term/1,
          set_last_index/2,
          handle_event/2,
@@ -70,6 +73,7 @@
                       {down, pid(), term()}.
 
 -type event() :: {ra_log_event, event_body()}.
+-type transform_fun() :: fun ((ra_index(), ra_term(), ra_server:command()) -> term()).
 
 -type effect() ::
     {delete_snapshot, Dir :: file:filename(), ra_idxterm()} |
@@ -84,7 +88,7 @@
 
 -record(cfg, {uid :: ra_uid(),
               log_id :: unicode:chardata(),
-              directory :: file:filename(),
+              directory :: file:filename_all(),
               min_snapshot_interval = ?MIN_SNAPSHOT_INTERVAL :: non_neg_integer(),
               min_checkpoint_interval = ?MIN_CHECKPOINT_INTERVAL :: non_neg_integer(),
               snapshot_module :: module(),
@@ -110,7 +114,11 @@
          tx = false :: boolean()
         }).
 
+-record(read_plan, {dir :: file:filename_all(),
+                    read :: #{ra_index() := log_entry()},
+                    plan :: ra_log_reader:read_plan()}).
 
+-opaque read_plan() :: #read_plan{}.
 -opaque state() :: #?MODULE{}.
 
 -type ra_log_init_args() :: #{uid := ra_uid(),
@@ -145,6 +153,7 @@
       atom() => term()}.
 
 -export_type([state/0,
+              read_plan/0,
               ra_log_init_args/0,
               ra_meta_key/0,
               segment_ref/0,
@@ -303,7 +312,6 @@ init(#{uid := UId,
             {SnapIdx, SnapTerm},
             State#?MODULE.last_written_index_term
            ]),
-    ?DEBUG("~ts: ra_log:init overview ~p", [overview(State)]),
     element(1, delete_segments(SnapIdx, State)).
 
 -spec close(state()) -> ok.
@@ -465,8 +473,9 @@ fold(From0, To0, Fun, Acc0,
 fold(_From, _To, _Fun, Acc, State) ->
     {Acc, State}.
 
-%% read a list of indexes,
-%% found indexes be returned in the same order as the input list of indexes
+%% @doc Reads a list of indexes.
+%% Found indexes are returned in the same order as the input list of indexes
+%% @end
 -spec sparse_read([ra_index()], state()) ->
     {[log_entry()], state()}.
 sparse_read(Indexes0, #?MODULE{cfg = Cfg,
@@ -488,8 +497,8 @@ sparse_read(Indexes0, #?MODULE{cfg = Cfg,
 
     %% drop any indexes that are larger than the last index available
     Indexes2 = lists:dropwhile(fun (I) -> I > LastIdx end, Indexes1),
-    {Entries0, CacheNumRead, Indexes} = ra_mt:get_items(Indexes2, Mt),
-    ok = incr_counter(Cfg, ?C_RA_LOG_READ_MEM_TBL, CacheNumRead),
+    {Entries0, MemTblNumRead, Indexes} = ra_mt:get_items(Indexes2, Mt),
+    ok = incr_counter(Cfg, ?C_RA_LOG_READ_MEM_TBL, MemTblNumRead),
     {Entries1, Reader} = ra_log_reader:sparse_read(Reader0, Indexes, Entries0),
     %% here we recover the original order of indexes
     Entries = case Sort of
@@ -507,6 +516,65 @@ sparse_read(Indexes0, #?MODULE{cfg = Cfg,
               end,
     {Entries, State#?MODULE{reader = Reader}}.
 
+
+%% read a list of indexes,
+%% found indexes be returned in the same order as the input list of indexes
+-spec partial_read([ra_index()], state(),
+                   fun ((ra_index(), ra_term(), ra_server:command()) -> term())
+                   ) ->
+    read_plan().
+partial_read(Indexes0, #?MODULE{cfg = Cfg,
+                                reader = Reader0,
+                                last_index = LastIdx,
+                                mem_table = Mt},
+            TransformFun) ->
+    ok = incr_counter(Cfg, ?C_RA_LOG_READ_OPS, 1),
+    %% indexes need to be sorted high -> low for correct and efficient reading
+    Sort = ra_lib:lists_detect_sort(Indexes0),
+    Indexes1 = case Sort of
+                   unsorted ->
+                       lists:sort(fun erlang:'>'/2, Indexes0);
+                   ascending ->
+                       lists:reverse(Indexes0);
+                   _ ->
+                       % descending or undefined
+                       Indexes0
+               end,
+
+    %% drop any indexes that are larger than the last index available
+    Indexes2 = lists:dropwhile(fun (I) -> I > LastIdx end, Indexes1),
+    {Entries0, MemTblNumRead, Indexes} = ra_mt:get_items(Indexes2, Mt),
+    ok = incr_counter(Cfg, ?C_RA_LOG_READ_MEM_TBL, MemTblNumRead),
+    Read = lists:foldl(fun ({I, T, Cmd}, Acc) ->
+                               maps:put(I, TransformFun(I, T, Cmd), Acc)
+                       end, #{}, Entries0),
+
+    Plan = ra_log_reader:read_plan(Reader0, Indexes),
+    #read_plan{dir = Cfg#cfg.directory,
+               read = Read,
+               plan = Plan}.
+
+
+-spec execute_read_plan(read_plan(), undefined | ra_flru:state(),
+                        TransformFun :: transform_fun()) ->
+    {#{ra_index() => Command :: term()}, ra_flru:state()}.
+execute_read_plan(#read_plan{dir = Dir,
+                             read = Read,
+                             plan = Plan}, Flru0, TransformFun) ->
+    ra_log_reader:exec_read_plan(Dir, Plan, Flru0, TransformFun, Read).
+
+-spec read_plan_info(read_plan()) -> map().
+read_plan_info(#read_plan{read = Read,
+                          plan = Plan}) ->
+    NumSegments = length(Plan),
+    NumInSegments = lists:foldl(fun ({_, Idxs}, Acc) ->
+                                        Acc + length(Idxs)
+                                end, 0, Plan),
+    #{num_read => map_size(Read),
+      num_in_segments => NumInSegments,
+      num_segments => NumSegments}.
+
+
 -spec last_index_term(state()) -> ra_idxterm().
 last_index_term(#?MODULE{last_index = LastIdx, last_term = LastTerm}) ->
     {LastIdx, LastTerm}.
@@ -1309,8 +1377,7 @@ put_counter(#cfg{counter = undefined}, _Ix, _N) ->
     ok.
 
 server_data_dir(Dir, UId) ->
-    Me = ra_lib:to_list(UId),
-    filename:join(Dir, Me).
+    filename:join(Dir, UId).
 
 maps_with_values(Keys, Map) ->
     lists:foldr(

src/ra_log_read_plan.erl

@@ -0,0 +1,20 @@
+%% This Source Code Form is subject to the terms of the Mozilla Public
+%% License, v. 2.0. If a copy of the MPL was not distributed with this
+%% file, You can obtain one at https://mozilla.org/MPL/2.0/.
+%%
+%% Copyright (c) 2017-2023 Broadcom. All Rights Reserved. The term Broadcom refers to Broadcom Inc. and/or its subsidiaries.
+%%
+-module(ra_log_read_plan).
+
+
+-export([execute/2,
+         info/1]).
+
+-spec execute(ra_log:read_plan(), undefined | ra_flru:state()) ->
+    {#{ra:index() => Command :: ra_server:command()}, ra_flru:state()}.
+execute(Plan, Flru) ->
+    ra_log:execute_read_plan(Plan, Flru, fun ra_server:transform_for_partial_read/3).
+
+-spec info(ra_log:read_plan()) -> map().
+info(Plan) ->
+    ra_log:read_plan_info(Plan).

src/ra_log_reader.erl

@@ -19,6 +19,8 @@
          update_first_index/2,
          fold/5,
          sparse_read/3,
+         read_plan/2,
+         exec_read_plan/5,
          fetch_term/2
          ]).
 
@@ -44,10 +46,12 @@
                 }).
 
 -opaque state() :: #?STATE{}.
+-type read_plan() :: [{BaseName :: file:filename_all(), [ra:index()]}].
 
 
 -export_type([
-              state/0
+              state/0,
+              read_plan/0
               ]).
 
 %% PUBLIC
@@ -170,13 +174,55 @@ sparse_read(#?STATE{cfg = #cfg{} = Cfg} = State, Indexes, Entries0) ->
     ok = incr_counter(Cfg, ?C_RA_LOG_READ_SEGMENT, SegC),
     {Entries, State#?MODULE{open_segments = Open}}.
 
+-spec read_plan(state(), [ra_index()]) -> read_plan().
+read_plan(#?STATE{segment_refs = SegRefs}, Indexes) ->
+    %% TODO: add counter for number of read plans requested
+    segment_read_plan(SegRefs, Indexes, []).
+
+-spec exec_read_plan(file:filename_all(), read_plan(), undefined | ra_flru:state(),
+                     TransformFun :: fun(),
+                     #{ra_index() => Command :: term()}) ->
+    {#{ra_index() => Command :: term()}, ra_flru:state()}.
+exec_read_plan(Dir, Plan, undefined, TransformFun, Acc0) ->
+    Open = ra_flru:new(1, fun({_, Seg}) -> ra_log_segment:close(Seg) end),
+    exec_read_plan(Dir, Plan, Open, TransformFun, Acc0);
+exec_read_plan(Dir, Plan, Open0, TransformFun, Acc0)
+  when is_list(Plan) ->
+    Fun = fun (I, T, B, Acc) ->
+                  E = TransformFun(I, T, binary_to_term(B)),
+                  Acc#{I => E}
+          end,
+    lists:foldl(
+      fun ({Idxs, BaseName}, {Acc1, Open1}) ->
+              {Seg, Open} = get_segment_ext(Dir, Open1, BaseName),
+              {_, Acc} = ra_log_segment:read_sparse(Seg, Idxs, Fun, Acc1),
+              {Acc, Open}
+      end, {Acc0, Open0}, Plan).
+
 -spec fetch_term(ra_index(), state()) -> {option(ra_index()), state()}.
 fetch_term(Idx, #?STATE{cfg = #cfg{} = Cfg} = State0) ->
     incr_counter(Cfg, ?C_RA_LOG_FETCH_TERM, 1),
     segment_term_query(Idx, State0).
 
 %% LOCAL
 
+segment_read_plan(_RegRefs, [], Acc) ->
+    lists:reverse(Acc);
+segment_read_plan([], _Indexes, Acc) ->
+    %% not all indexes were found
+    lists:reverse(Acc);
+segment_read_plan([{To, From, Fn} | SegRefs], Indexes, Acc) ->
+    %% TODO: address unnecessary allocation here
+    Range = {To, From},
+    case sparse_read_split(fun (I) ->
+                                   ra_range:in(I, Range)
+                           end, Indexes, []) of
+        {[], _} ->
+            segment_read_plan(SegRefs, Indexes, Acc);
+        {Idxs, Rem} ->
+            segment_read_plan(SegRefs, Rem, [{Idxs, Fn} | Acc])
+    end.
+
 segment_term_query(Idx, #?MODULE{segment_refs = SegRefs,
                                  cfg = Cfg,
                                  open_segments = OpenSegs} = State) ->
@@ -255,7 +301,10 @@ segment_sparse_read(#?STATE{segment_refs = SegRefs,
                                     end, Idxs, []),
               {ReadSparseCount, Entries} =
                   ra_log_segment:read_sparse(Seg, ReadIdxs,
-                                             fun binary_to_term/1, []),
+                                             fun (I, T, B, Acc) ->
+                                                     [{I, T, binary_to_term(B)} | Acc]
+                                             end,
+                                             []),
               {Open, RemIdxs, C +  ReadSparseCount,
                lists:reverse(Entries, En0)};
          (_Segref, Acc) ->
@@ -294,6 +343,24 @@ get_segment(#cfg{directory = Dir,
             end
     end.
 
+get_segment_ext(Dir, Open0, Fn) ->
+    case ra_flru:fetch(Fn, Open0) of
+        {ok, S, Open1} ->
+            {S, Open1};
+        error ->
+            AbsFn = filename:join(Dir, Fn),
+            case ra_log_segment:open(AbsFn,
+                                     #{mode => read,
+                                       access_pattern => random})
+            of
+                {ok, S} ->
+                    {S, ra_flru:insert(Fn, S, Open0)};
+                {error, Err} ->
+                    exit({ra_log_failed_to_open_segment, Err,
+                          AbsFn})
+            end
+    end.
+
 compact_seg_refs([], PreviousSegRefs) ->
     PreviousSegRefs;
 compact_seg_refs(NewSegRefs, []) ->