Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update chapter 16 #70

Merged
merged 15 commits into from
Sep 10, 2024
Merged

Update chapter 16 #70

merged 15 commits into from
Sep 10, 2024

Conversation

JeffreyRStevens
Copy link
Contributor

  • Change all references to S7 (instead of OOP-WG)
  • Add OOP comparison table
  • Clean up text

jonthegeek
jonthegeek previously approved these changes Sep 10, 2024
Copy link
Member

@jonthegeek jonthegeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to commit these changes myself, so there will probably be another review in a moment. In general:

  • Make all the slides unnumbered ({-}), and don't manually number things. If they insert a section, we don't want to have to update our slides for things to make sense, and we don't want slides numbered in general.
  • In general aim for a more slide-like feel for some of these... but it's better than what was there, so I'm not rejecting the slides or anything!

Thanks!

16_Trade-offs.Rmd Outdated Show resolved Hide resolved
16_Trade-offs.Rmd Outdated Show resolved Hide resolved
16_Trade-offs.Rmd Outdated Show resolved Hide resolved
16_Trade-offs.Rmd Outdated Show resolved Hide resolved
16_Trade-offs.Rmd Outdated Show resolved Hide resolved
16_Trade-offs.Rmd Outdated Show resolved Hide resolved
16_Trade-offs.Rmd Outdated Show resolved Hide resolved
16_Trade-offs.Rmd Outdated Show resolved Hide resolved
16_Trade-offs.Rmd Outdated Show resolved Hide resolved
16_Trade-offs.Rmd Outdated Show resolved Hide resolved
@jonthegeek
Copy link
Member

The error doesn't appear to be you. I'm setting a reminder for myself to come back and try this again later today or tomorrow!

Copy link
Member

@jonthegeek jonthegeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again! The action runs now, so it must have been a curl issue (ie, not us).

@jonthegeek jonthegeek merged commit e4a24be into r4ds:main Sep 10, 2024
1 check passed
@JeffreyRStevens JeffreyRStevens deleted the jeff-ch16-update branch September 11, 2024 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants