Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suppress message from the 'helper' method. #264

Merged
merged 2 commits into from
Aug 9, 2023

Conversation

maciekbanas
Copy link
Member

No description provided.

Copy link
Collaborator

@Cotau Cotau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would leave contributors info for for the methods where its automatically gathered by API as the argument for contributors for GraphQL has no default so it would be left for user responsibility here. I would just add info in function manual how it works and why it might leave empty column with a tradeoff of faster scraping.

…ries by `team`, expand documentation on the `add_contributors` parameter.
@maciekbanas maciekbanas requested a review from Cotau August 8, 2023 16:57
@maciekbanas
Copy link
Member Author

maciekbanas commented Aug 8, 2023

@Cotau I expanded docs on the add_contributors parameter. To leave no confusion to the user I set the parameter to TRUE when pulling repositories by team and it stays by default FALSE when pulling by org and phrase. Please re-review.

Copy link
Collaborator

@Cotau Cotau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good now!

@maciekbanas maciekbanas merged commit 0b28119 into devel Aug 9, 2023
3 of 4 checks passed
@maciekbanas maciekbanas deleted the 254-remove-pulling-contributors-info branch August 9, 2023 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When pulling GitLab repos with REST there should not pop out automatically "pulling contributors"
2 participants