Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hansard #76

Open
wants to merge 16 commits into
base: main
Choose a base branch
from
Open

Hansard #76

wants to merge 16 commits into from

Conversation

baberabb
Copy link
Contributor

No description provided.

@baberabb baberabb marked this pull request as draft May 27, 2024 10:59
@baberabb baberabb marked this pull request as ready for review June 1, 2024 18:29
blester125
blester125 requested changes Jun 10, 2024
View reviewed changes
Copy link
Collaborator

@blester125 blester125 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Listed out some changes for readability and organization. I think we should also remove all the COUNT global variable stuff. I can whip up a counting tool with dolma pretty quick

hansard/ca_to_dolma.py Outdated Show resolved Hide resolved
hansard/ca_to_dolma.py Outdated Show resolved Hide resolved
hansard/ca_to_dolma.py Outdated Show resolved Hide resolved
hansard/ca_to_dolma.py Outdated Show resolved Hide resolved
hansard/ca_to_dolma.py Outdated Show resolved Hide resolved
hansard/uk_to_dolma.py Outdated Show resolved Hide resolved
hansard/uk_to_dolma.py Show resolved Hide resolved
hansard/uk_to_dolma.py Show resolved Hide resolved
hansard/uk_to_dolma.py Show resolved Hide resolved
hansard/uk_to_dolma.py Show resolved Hide resolved
@baberabb
Copy link
Contributor Author

@blester125 incorporated all your comments. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blester125 blester125 blester125 requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@baberabb @blester125