Adding app-name-matcher to Action params #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karoun
commented
Dec 5, 2024
| @@ -0,0 +1,16 @@ | |||
| name: "build" | |||
There was a problem hiding this comment.
Pulled into separate CI step so it can pass and be required by GitHub Branch Protection Rules
rgoldfinger-quizlet
approved these changes
Dec 6, 2024
|
|
||
| const changedFiles = await getChangedFiles(); | ||
| core.info(`Changed files: ${changedFiles.join(', ')}`); | ||
| const appsAffected = repoApps.filter(partOfApp.bind(null, changedFiles)); |
There was a problem hiding this comment.
potential behavior change here?
There was a problem hiding this comment.
Good to flag, but no change. Not sure why I did this though, it's unnecessarily clever 😅
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
app-name-matcherallows for directly matching app names or providing a regexmain.tsso that nothing runs upon module import (important for testing)Test plan
buildCI step passes