Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only show apps with real diff #49

Merged
merged 1 commit into from
Aug 19, 2024
Merged

Only show apps with real diff #49

merged 1 commit into from
Aug 19, 2024

Conversation

aaron-weisberg-qz
Copy link
Contributor

@aaron-weisberg-qz aaron-weisberg-qz commented Aug 19, 2024 •
edited
Loading

  • Only shows apps that actually have a diff
  • Removes the argocd instance and part-of labels of the diff
  • E.x. new diff output

@aaron-weisberg-qz aaron-weisberg-qz changed the title check if there's a diff Only show apps with real diff Aug 19, 2024
@mattmelgard-qz
Copy link

mattmelgard-qz commented Aug 19, 2024 •
edited
Loading

Just to follow the code changes a little better, and maybe for posterity, it might be good to include some samples of before/after if you have some links to example change-sets

@aaron-weisberg-qz aaron-weisberg-qz merged commit 00ffb25 into master Aug 19, 2024
0 of 2 checks passed
@aaron-weisberg-qz aaron-weisberg-qz deleted the clean-diff branch August 19, 2024 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattmelgard-qz mattmelgard-qz mattmelgard-qz approved these changes

@samvanryssegem-qz samvanryssegem-qz samvanryssegem-qz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aaron-weisberg-qz @mattmelgard-qz @samvanryssegem-qz