Update action #41
Merged
Update action #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaron-weisberg-qz
force-pushed
the
update-action
branch
from
4c89d25 to
ac6029b
Compare
|
I'm not quite following this PR. Seems like it allows apps to not specify their deployed versions, in favor of always using the latest |
Yes, that's correct. Our ArgoCD apps in the new cluster rely on the default The other change is just to delete old diff comments before posting the new one. |
michaelellenburg-qz
approved these changes
Dec 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
Our new argocd app don't actually specify a
targetRevisionbut instead rely on the defaultHEAD.Modifications
targetRevisionin-addition tomasterormain