Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add FileSink with pluggable destinations
This PR introduces a new design for the FileSink that separates storage concerns from data serialization. The main changes include:
Key Changes
FileSink
to use a pluggable destination systemDestination
class to define the storage interfaceLocalDestination
for writing to local filesystemS3Destination
for writing to Amazon S3 bucketsBenefits
Implementation Details
FileSink
now accepts adestination
parameter that defaults toLocalDestination
write()
,set_directory()
, etc.Documentation