Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: Implement mypy pre-commit check #643

Merged
merged 4 commits into from
Nov 27, 2024
Merged

CI: Implement mypy pre-commit check #643

merged 4 commits into from
Nov 27, 2024

Conversation

quentin-quix
Copy link
Contributor

@quentin-quix quentin-quix commented Nov 20, 2024 •
edited
Loading

  • Add mypy check in pre-commit
  • Fix typing in various places
  • Split consumer into BaseConsumer/Consumer/RowConsumer to support accepting different topic type (str and Topic) in subscribe

quentin-quix
quentin-quix commented Nov 20, 2024
View reviewed changes
quixstreams/app.py Outdated Show resolved Hide resolved
@quentin-quix quentin-quix force-pushed the mypy branch 3 times, most recently from 170b450 to 9555406 Compare November 25, 2024 11:52
@quentin-quix quentin-quix marked this pull request as ready for review November 25, 2024 12:05
gwaramadze
gwaramadze reviewed Nov 27, 2024
View reviewed changes
pyproject.toml Outdated Show resolved Hide resolved
gwaramadze
gwaramadze previously approved these changes Nov 27, 2024
View reviewed changes
@quentin-quix quentin-quix merged commit ccef54a into main Nov 27, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gwaramadze gwaramadze gwaramadze approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@quentin-quix @gwaramadze