-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Protobuf SerDes support #402
Conversation
b09fe6d
to
0942db8
Compare
0942db8
to
8bc06a2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @quentin-quix, it looks good overall, with only a few minor comments 👍
Question: How well does it work with more complex Protobuf types like Enums? E.g., Enum can be deserialized as enum.Enum
and as an int.
Do we cover that?
Also, please remember to add the info about Protobuf to the docs (see docs/advanced/serialization.md
).
8bc06a2
to
a3fc56a
Compare
There is an argument for it that we should expose, |
6e942bd
to
357e373
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think new serdes classes need to be imported and added to SERIALIZERS
and DESERIALIZERS
maps in quixstreams.models.serializers.__init__
We don't want to do it for protobuf since it needs an extra import. Importing it in |
018cbfe
to
fde4dc5
Compare
fde4dc5
to
7a982dc
Compare
No description provided.