Skip to content

Commit

Permalink
final tweaks before merging
Browse files Browse the repository at this point in the history
  • Loading branch information
tim-quix committed Nov 22, 2024
1 parent 21569ec commit 802b085
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 6 deletions.
3 changes: 2 additions & 1 deletion conda/meta.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,8 @@ requirements:
- google-cloud-bigquery >=3.26.0,<3.27
- google-cloud-pubsub >=2.23.1,<3
- psycopg2-binary >=2.9.9,<3
- boto3 >=1.35.60,<2.0
- boto3 >=1.35.65,<2.0
- boto3-stubs >=1.35.65,<2.0

test:
imports:
Expand Down
3 changes: 2 additions & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,8 @@ all = [
"google-cloud-bigquery>=3.26.0,<3.27",
"google-cloud-pubsub>=2.23.1,<3",
"psycopg2-binary>=2.9.9,<3",
"boto3>=1.35.60,<2.0",
"boto3>=1.35.65,<2.0",
"boto3-stubs>=1.35.65,<2.0",
]

avro = ["fastavro>=1.8,<2.0"]
Expand Down
9 changes: 5 additions & 4 deletions quixstreams/sources/community/kinesis/kinesis.py
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
from os import getenv
from typing import Optional

from quixstreams.models.topics import Topic
Expand Down Expand Up @@ -56,10 +57,10 @@ class KinesisSource(StatefulSource):
def __init__(
self,
stream_name: str,
aws_region: Optional[str] = None,
aws_access_key_id: Optional[str] = None,
aws_secret_access_key: Optional[str] = None,
aws_endpoint_url: Optional[str] = None,
aws_region: Optional[str] = getenv("AWS_REGION"),
aws_access_key_id: Optional[str] = getenv("AWS_ACCESS_KEY_ID"),
aws_secret_access_key: Optional[str] = getenv("AWS_SECRET_ACCESS_KEY"),
aws_endpoint_url: Optional[str] = getenv("AWS_ENDPOINT_URL_KINESIS"),
shutdown_timeout: float = 10,
auto_offset_reset: AutoOffsetResetType = "latest",
max_records_per_shard: int = 1000,
Expand Down

0 comments on commit 802b085

Please sign in to comment.