Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(quinn-proto): Allow notifying of network path changes #2025

Merged
merged 1 commit into from
Nov 5, 2024

Conversation

flub
Copy link
Contributor

@flub flub commented Oct 31, 2024

This gives the proto state the ability to be externally notified about network path changes it might not be aware off. In this case it will re-set the RTT, Congestion Controller and MTU settings to the initial states based on the TransportConfig.

This addresses the quinn-proto part of #2018.

Copy link
Collaborator

@Ralith Ralith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

quinn-proto/src/connection/paths.rs Outdated Show resolved Hide resolved
quinn-proto/src/connection/mod.rs Outdated Show resolved Hide resolved
quinn-proto/src/connection/mod.rs Outdated Show resolved Hide resolved
quinn-proto/src/connection/mod.rs Outdated Show resolved Hide resolved
@flub flub requested a review from Ralith November 5, 2024 16:45
@flub
Copy link
Contributor Author

flub commented Nov 5, 2024

I'll --autosquash the commits once it gets an LGTM. In the meantime it's easier to track changes by using fixup commits.

Copy link
Collaborator

@Ralith Ralith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

This gives the proto state the ability to be externally notified about
network path changes it might not be aware off.  In this case it will
re-set the RTT, Congestion Controller and MTU settings to the initial
states based on the TransportConfig.

This addresses the quinn-proto part of quinn-rs#2018.
@flub flub force-pushed the flub/path-changed branch from 4568a31 to c2d66a7 Compare November 5, 2024 19:43
@flub
Copy link
Contributor Author

flub commented Nov 5, 2024

thanks, rebased on main and squashed

@djc djc added this pull request to the merge queue Nov 5, 2024
Merged via the queue into quinn-rs:main with commit 4974621 Nov 5, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants