Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JsonEditor: Handle anyOf, oneOf and internal ref #4256

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

fiskus
Copy link
Member

@fiskus fiskus commented Dec 9, 2024

Description

TODO

  • Unit tests
  • Automated tests (e.g. Preflight)
  • Confirm that this change meets security best practices and does not violate the security model
  • Documentation
    • run optipng on any new PNGs
    • Python: Run build.py for new docstrings
    • JavaScript: basic explanation and screenshot of new features
    • Markdown somewhere in docs/**/*.md that explains the feature to end users (said .md files should be linked from SUMMARY.md so they appear on https://docs.quiltdata.com)
    • Markdown docs for developers
  • Changelog entry (skip if change is not significant to end users, e.g. docs only)

Copy link

codecov bot commented Dec 9, 2024

Codecov Report

Attention: Patch coverage is 18.51852% with 44 lines in your changes missing coverage. Please review.

Project coverage is 37.56%. Comparing base (cda3d76) to head (d865b94).

Files with missing lines Patch % Lines
catalog/app/utils/JSONSchema/JSONSchema.ts 3.03% 32 Missing ⚠️
catalog/app/components/JsonEditor/State.ts 33.33% 12 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4256      +/-   ##
==========================================
- Coverage   37.59%   37.56%   -0.03%     
==========================================
  Files         769      769              
  Lines       33984    34034      +50     
  Branches     5156     5176      +20     
==========================================
+ Hits        12775    12784       +9     
- Misses      20665    20706      +41     
  Partials      544      544              
Flag Coverage Δ
api-python 91.29% <ø> (ø)
catalog 15.61% <18.51%> (+<0.01%) ⬆️
lambda 91.48% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant