Catalog: Admin: Tabulator Settings (unrestricted access)

[nl0]

Description

TODO

• Documentation
  • run optipng on any new PNGs
  • JavaScript: basic explanation and screenshot of new features
  • Markdown somewhere in docs/**/*.md that explains the feature to end users (said .md files should be linked from SUMMARY.md so they appear on https://docs.quiltdata.com)
• Changelog entry (skip if change is not significant to end users, e.g. docs only)

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 40 lines in your changes missing coverage. Please review.

Project coverage is 37.54%. Comparing base (ea89fb9) to head (7025aad).

Files with missing lines	Patch %	Lines
...pp/containers/Admin/Settings/TabulatorSettings.tsx	0.00%	30 Missing and 1 partial ⚠️
catalog/app/utils/GraphQL/Provider.tsx	0.00%	4 Missing ⚠️
...Settings/gql/SetTabulatorUnrestricted.generated.ts	0.00%	2 Missing ⚠️
...in/Settings/gql/TabulatorUnrestricted.generated.ts	0.00%	2 Missing ⚠️
catalog/app/containers/Admin/Settings/Settings.tsx	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #4255      +/-   ##
==========================================
- Coverage   37.59%   37.54%   -0.05%     
==========================================
  Files         769      772       +3     
  Lines       33984    34024      +40     
  Branches     5361     5365       +4     
==========================================
  Hits        12775    12775              
- Misses      20022    20061      +39     
- Partials     1187     1188       +1     

Flag	Coverage Δ
api-python	91.29% <ø> (ø)
catalog	15.58% <0.00%> (-0.03%)	⬇️
lambda	91.48% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[nl0]

@drernie i'd appreciate some help with the documentation

Copilot reviewed 6 out of 14 changed files in this pull request and generated no suggestions.

Files not reviewed (8)

• catalog/app/containers/Admin/Settings/gql/SetTabulatorUnrestricted.graphql: Language not supported
• catalog/app/containers/Admin/Settings/gql/TabulatorUnrestricted.graphql: Language not supported
• shared/graphql/schema.graphql: Language not supported
• .github/workflows/deploy-catalog.yaml: Evaluated as low risk
• catalog/CHANGELOG.md: Evaluated as low risk
• catalog/app/containers/Admin/Settings/Settings.tsx: Evaluated as low risk
• catalog/app/containers/Admin/Settings/TabulatorSettings.tsx: Evaluated as low risk
• catalog/app/containers/Admin/Settings/gql/SetTabulatorUnrestricted.generated.ts: Evaluated as low risk

[fiskus]

I have to admit, seeing the * in the CSS scared me a little at first. But looking closer, it’s actually clever and even performant!

On the other hand, I’m still struggling to see the benefits of using Effect here. It seems to make the code more verbose and less idiomatic compared to simpler approaches like comparing to null. I feel I’ve expressed my concerns about Effect clearly at this point, so I won’t bring it up again.

That said, the implementation is solid, and I appreciate the attention to detail.

[nl0]

I have to admit, seeing the * in the CSS scared me a little at first. But looking closer, it’s actually clever and even performant!

i was sure it's an established pattern =)

On the other hand, I’m still struggling to see the benefits of using Effect here. It seems to make the code more verbose and less idiomatic compared to simpler approaches like comparing to null. I feel I’ve expressed my concerns about Effect clearly at this point, so I won’t bring it up again.

fair enough

That said, the implementation is solid, and I appreciate the attention to detail.

thanks

[nl0]

@sir-sigurd @fiskus pls see if the documentation changes make sense

Copilot reviewed 6 out of 14 changed files in this pull request and generated no suggestions.

Files not reviewed (8)

• catalog/app/containers/Admin/Settings/gql/SetTabulatorUnrestricted.graphql: Language not supported
• catalog/app/containers/Admin/Settings/gql/TabulatorUnrestricted.graphql: Language not supported
• shared/graphql/schema.graphql: Language not supported
• catalog/app/containers/Admin/Settings/Settings.tsx: Evaluated as low risk
• catalog/app/containers/Admin/Settings/TabulatorSettings.tsx: Evaluated as low risk
• catalog/app/containers/Admin/Settings/gql/SetTabulatorUnrestricted.generated.ts: Evaluated as low risk
• catalog/app/containers/Admin/Settings/gql/TabulatorUnrestricted.generated.ts: Evaluated as low risk
• catalog/app/model/graphql/schema.generated.ts: Evaluated as low risk

[sir-sigurd]

you also can use quilt3 for this
or Quilt Catalog == registry here?

[nl0]

well, basically, yes

[nl0]

@QuiltSimon @drernie @sir-sigurd @akarve pls see if the documentation is good enough