-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
quilt_summarize.json
editor
#4254
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4254 +/- ##
==========================================
+ Coverage 37.59% 38.33% +0.74%
==========================================
Files 769 773 +4
Lines 33984 34269 +285
Branches 5156 5418 +262
==========================================
+ Hits 12775 13137 +362
+ Misses 20665 19954 -711
- Partials 544 1178 +634
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 6 out of 20 changed files in this pull request and generated no suggestions.
Files not reviewed (14)
- catalog/app/components/FileEditor/QuiltConfigEditor/QuiltSummarize/index.ts: Evaluated as low risk
- catalog/app/components/FileEditor/loader.ts: Evaluated as low risk
- catalog/app/components/FileEditor/loader.spec.ts: Evaluated as low risk
- catalog/app/components/FileEditor/State.tsx: Evaluated as low risk
- catalog/app/components/FileEditor/QuiltConfigEditor/WorkflowsToolbar.tsx: Evaluated as low risk
- catalog/app/components/FileEditor/HelpLinks.tsx: Evaluated as low risk
- catalog/app/containers/Bucket/requests/object.spec.ts: Evaluated as low risk
- catalog/CHANGELOG.md: Evaluated as low risk
- catalog/app/containers/Bucket/PackageTree/PackageTree.tsx: Evaluated as low risk
- catalog/app/components/FileEditor/CreateFile.tsx: Evaluated as low risk
- catalog/app/components/FileEditor/index.ts: Evaluated as low risk
- catalog/app/components/FileEditor/FileEditor.tsx: Evaluated as low risk
- catalog/app/components/FileEditor/types.ts: Evaluated as low risk
- catalog/app/components/Preview/loaders/summarize.ts: Evaluated as low risk
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 9 out of 24 changed files in this pull request and generated no suggestions.
Files not reviewed (15)
- catalog/app/components/FileEditor/QuiltConfigEditor/QuiltSummarize/snapshots/QuiltSummarize.spec.tsx.snap: Language not supported
- catalog/app/components/FileEditor/snapshots/FileEditor.spec.tsx.snap: Language not supported
- catalog/CHANGELOG.md: Evaluated as low risk
- catalog/app/components/FileEditor/CreateFile.tsx: Evaluated as low risk
- catalog/app/components/FileEditor/FileEditor.spec.tsx: Evaluated as low risk
- catalog/app/components/FileEditor/FileEditor.tsx: Evaluated as low risk
- catalog/app/components/FileEditor/HelpLinks.tsx: Evaluated as low risk
- catalog/app/components/FileEditor/QuiltConfigEditor/QuiltSummarize/QuiltSummarize.spec.tsx: Evaluated as low risk
- catalog/app/components/FileEditor/QuiltConfigEditor/QuiltSummarize/State.spec.tsx: Evaluated as low risk
- catalog/app/components/FileEditor/QuiltConfigEditor/QuiltSummarize/State.tsx: Evaluated as low risk
- catalog/app/components/FileEditor/QuiltConfigEditor/QuiltSummarize/index.ts: Evaluated as low risk
- catalog/app/components/FileEditor/QuiltConfigEditor/WorkflowsToolbar.tsx: Evaluated as low risk
- catalog/app/components/FileEditor/State.tsx: Evaluated as low risk
- catalog/app/components/FileEditor/index.ts: Evaluated as low risk
- catalog/app/components/FileEditor/loader.spec.ts: Evaluated as low risk
Comments skipped due to low confidence (1)
catalog/app/components/FileEditor/loader.ts:13
- The term 'fulfilled' is misspelled as 'fullfilled'.
const cache: { [index in Mode]?: Promise<void> | 'fulfilled' } = {}
Added
__quiltSummarize
type forQuiltConfigEditor
. But the plan is to replace the universalQuiltConfigEditor
component with three custom forms.QuiltSummarize
is the first one.