Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

quilt_summarize.json editor #4254

Open
wants to merge 45 commits into
base: master
Choose a base branch
from
Open

quilt_summarize.json editor #4254

wants to merge 45 commits into from

Conversation

fiskus
Copy link
Member

@fiskus fiskus commented Dec 5, 2024

Screenshot from 2024-12-09 15-21-12

Added __quiltSummarize type for QuiltConfigEditor. But the plan is to replace the universal QuiltConfigEditor component with three custom forms.

QuiltSummarize is the first one.

  • Unit tests
  • Changelog entry (skip if change is not significant to end users, e.g. docs only)

Copy link

codecov bot commented Dec 5, 2024

Codecov Report

Attention: Patch coverage is 63.69637% with 110 lines in your changes missing coverage. Please review.

Project coverage is 38.33%. Comparing base (cda3d76) to head (04d64b9).

Files with missing lines Patch % Lines
...uiltConfigEditor/QuiltSummarize/QuiltSummarize.tsx 45.08% 95 Missing ⚠️
catalog/app/components/FileEditor/FileEditor.tsx 60.00% 8 Missing ⚠️
...eEditor/QuiltConfigEditor/QuiltSummarize/State.tsx 96.38% 3 Missing ⚠️
.../app/containers/Bucket/PackageTree/PackageTree.tsx 0.00% 2 Missing ⚠️
...leEditor/QuiltConfigEditor/QuiltSummarize/index.ts 0.00% 1 Missing ⚠️
catalog/app/components/FileEditor/index.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4254      +/-   ##
==========================================
+ Coverage   37.59%   38.33%   +0.74%     
==========================================
  Files         769      773       +4     
  Lines       33984    34269     +285     
  Branches     5156     5418     +262     
==========================================
+ Hits        12775    13137     +362     
+ Misses      20665    19954     -711     
- Partials      544     1178     +634     
Flag Coverage Δ
api-python 91.29% <ø> (ø)
catalog 16.91% <63.69%> (+1.30%) ⬆️
lambda 91.48% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fiskus fiskus marked this pull request as ready for review December 10, 2024 17:45
@fiskus fiskus requested a review from Copilot December 11, 2024 15:19

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 6 out of 20 changed files in this pull request and generated no suggestions.

Files not reviewed (14)
  • catalog/app/components/FileEditor/QuiltConfigEditor/QuiltSummarize/index.ts: Evaluated as low risk
  • catalog/app/components/FileEditor/loader.ts: Evaluated as low risk
  • catalog/app/components/FileEditor/loader.spec.ts: Evaluated as low risk
  • catalog/app/components/FileEditor/State.tsx: Evaluated as low risk
  • catalog/app/components/FileEditor/QuiltConfigEditor/WorkflowsToolbar.tsx: Evaluated as low risk
  • catalog/app/components/FileEditor/HelpLinks.tsx: Evaluated as low risk
  • catalog/app/containers/Bucket/requests/object.spec.ts: Evaluated as low risk
  • catalog/CHANGELOG.md: Evaluated as low risk
  • catalog/app/containers/Bucket/PackageTree/PackageTree.tsx: Evaluated as low risk
  • catalog/app/components/FileEditor/CreateFile.tsx: Evaluated as low risk
  • catalog/app/components/FileEditor/index.ts: Evaluated as low risk
  • catalog/app/components/FileEditor/FileEditor.tsx: Evaluated as low risk
  • catalog/app/components/FileEditor/types.ts: Evaluated as low risk
  • catalog/app/components/Preview/loaders/summarize.ts: Evaluated as low risk
@fiskus fiskus requested a review from nl0 December 11, 2024 15:25
@fiskus fiskus requested a review from Copilot December 12, 2024 13:19

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 9 out of 24 changed files in this pull request and generated no suggestions.

Files not reviewed (15)
  • catalog/app/components/FileEditor/QuiltConfigEditor/QuiltSummarize/snapshots/QuiltSummarize.spec.tsx.snap: Language not supported
  • catalog/app/components/FileEditor/snapshots/FileEditor.spec.tsx.snap: Language not supported
  • catalog/CHANGELOG.md: Evaluated as low risk
  • catalog/app/components/FileEditor/CreateFile.tsx: Evaluated as low risk
  • catalog/app/components/FileEditor/FileEditor.spec.tsx: Evaluated as low risk
  • catalog/app/components/FileEditor/FileEditor.tsx: Evaluated as low risk
  • catalog/app/components/FileEditor/HelpLinks.tsx: Evaluated as low risk
  • catalog/app/components/FileEditor/QuiltConfigEditor/QuiltSummarize/QuiltSummarize.spec.tsx: Evaluated as low risk
  • catalog/app/components/FileEditor/QuiltConfigEditor/QuiltSummarize/State.spec.tsx: Evaluated as low risk
  • catalog/app/components/FileEditor/QuiltConfigEditor/QuiltSummarize/State.tsx: Evaluated as low risk
  • catalog/app/components/FileEditor/QuiltConfigEditor/QuiltSummarize/index.ts: Evaluated as low risk
  • catalog/app/components/FileEditor/QuiltConfigEditor/WorkflowsToolbar.tsx: Evaluated as low risk
  • catalog/app/components/FileEditor/State.tsx: Evaluated as low risk
  • catalog/app/components/FileEditor/index.ts: Evaluated as low risk
  • catalog/app/components/FileEditor/loader.spec.ts: Evaluated as low risk
Comments skipped due to low confidence (1)

catalog/app/components/FileEditor/loader.ts:13

  • The term 'fulfilled' is misspelled as 'fullfilled'.
const cache: { [index in Mode]?: Promise<void> | 'fulfilled' } = {}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant