Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: check for running VM processes using kill -0 #182

Merged
merged 1 commit into from
Jul 3, 2024
Merged

Conversation

flexiondotorg
Copy link
Member

Description

Change how VM processes are inspected to test if they are running but using kill -0 <pid>. Use kill -0 is portable between macOS and Linux and the BSD and GNU tools. quickemu also uses kill -0, which was introduced as part of the macOS porting work.

I've tested this on Linux to make sure there are no regressions; it needs validating on macOS.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • I have performed a self-review of my code
  • I have tested my code in common scenarios and confirmed there are no regressions
  • I have added comments to my code, particularly in hard-to-understand sections

@flexiondotorg flexiondotorg requested a review from ymauray July 3, 2024 10:34
Copy link
Member

@ymauray ymauray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me ! The "stop" button is active when the VM is running.

@flexiondotorg flexiondotorg merged commit 679f5c3 into main Jul 3, 2024
4 checks passed
@flexiondotorg flexiondotorg deleted the pid branch July 3, 2024 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: [macos_desktop] active VMs are not detected
2 participants