fix(fedora): handle the space in the beta release #1492
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
fixes quickemu-project#1462 adjust the RELEASE to remove and replace the space a couple of fails remain due to combinations that are not available FAIL: fedora-40-KDE_Mobile FAIL: fedora-40-MiracleWM FAIL: fedora-39-KDE_Mobile FAIL: fedora-39-MiracleWM FAIL: fedora-39-Onyx FAIL: fedora-39-Sericea
philclifford
force-pushed
the
fix-fedora
branch
from
75ccfaa to
e0557d5
Compare
philclifford
force-pushed
the
fix-fedora
branch
from
939dcce to
36cc0e9
Compare
|
Why specifically handle 41 Beta? Surely the same issue will appear down the line with 42 Beta, 43 Beta, etc. Spaces should be handled universally. |
Yes - assuming they continue to use an underline to replace space everywhere except the release json going forward and do release betas ... I chose not to assume anything and fix the one thing that was before me. A robust universal space-handling approach would be better. This works now. |
Handle all fedora release names with spaces
lj3954
approved these changes
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1462
adjust the RELEASE to remove and replace the space a couple of fails remain due to combinations that are not available
fixes #1493
Only available EDITIONs are presented (or tested) per RELEASE
Type of change
Checklist: