Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Improve quickget custom configurations, including unattended windows support #1373

Merged
merged 6 commits into from
Jul 14, 2024
Merged

feat: Improve quickget custom configurations, including unattended windows support #1373

merged 6 commits into from
Jul 14, 2024

Conversation

sudoAlphaX
Copy link
Contributor

@sudoAlphaX sudoAlphaX commented Jul 10, 2024 •
edited by lj3954
Loading

  • refactor: move create_config function to the bottom
  • refactor: move unattended win installation code inside function
  • feat: add --unattended flag to --create-config to create unattend.iso (windows hosts)

Description

Ability to pass in --unattended to --create-config to create unattended.iso and download VirtIO drivers for Windows guests.

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist:

  • I have performed a self-review of my code
  • I have tested my code in common scenarios and confirmed there are no regressions
  • I have added comments to my code, particularly in hard-to-understand sections
  • I have made corresponding changes to the documentation (remove if no documentation changes were required)

@sudoAlphaX
refactor: move create_config function to the bottom
71e7530 
move it below unattended_windows and web_get functions to reference them
later
@sudoAlphaX
refactor: move unattended win installation code inside function
4133dcd 
move code necessary for creation of unattended.iso for windows 10 and 11
inside unattended_windows function

Change parameter required for unattended_windows function from
autounattend.xml file to $VM_PATH
@sudoAlphaX
feat: add --unattended flag to --create-config to create unattend.iso…
d598714 
… (windows hosts)

Feature request #1369
@sudoAlphaX sudoAlphaX changed the title Unattended Windows installation with local iso feat: Unattended Windows installation with local iso Jul 10, 2024
lj3954
lj3954 requested changes Jul 11, 2024
View reviewed changes
Copy link
Member

@lj3954 lj3954 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think requiring a specific flag is suboptimal for quickget. We should try to determine whether or not unattended installation should be used automatically, by default.

quickget Outdated Show resolved Hide resolved
quickget Outdated Show resolved Hide resolved
quickget Outdated Show resolved Hide resolved
quickget Outdated Show resolved Hide resolved
quickget Outdated Show resolved Hide resolved
quickget Show resolved Hide resolved
quickget Outdated Show resolved Hide resolved
quickget Outdated Show resolved Hide resolved
@lj3954 lj3954 changed the title feat: Unattended Windows installation with local iso feat: Improve quickget custom configurations, including unattended windows support Jul 11, 2024
@lj3954 lj3954 added the enhancement New feature or request label Jul 11, 2024
sudoAlphaX and others added 2 commits July 12, 2024 01:47
@sudoAlphaX @lj3954
refactor: use unattended windows installation by default
8606824 
Create unattended windows installation iso by default when creating
windows vms with --create-config.
To disable, pass --disable-unattended

https://github.com/quickemu-project/quickemu/pull/1373/files#r1673481239

Co-authored-by: Liam <[email protected]>
@lj3954
fix: Don't duplicate VM path in fixed ISO from create_config function
fa73ba6
@lj3954 lj3954 requested a review from flexiondotorg July 11, 2024 21:18
@flexiondotorg flexiondotorg merged commit 885d4a8 into quickemu-project:master Jul 14, 2024
6 checks passed
@sudoAlphaX sudoAlphaX mentioned this pull request Jul 14, 2024
Closed
4 tasks
@sudoAlphaX sudoAlphaX deleted the unattended-windows branch July 14, 2024 19:04
@lj3954 lj3954 mentioned this pull request Sep 30, 2024
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lj3954 lj3954 lj3954 approved these changes

@flexiondotorg flexiondotorg flexiondotorg approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: create unattended windows installations with --create-config
3 participants
@sudoAlphaX @flexiondotorg @lj3954