Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: download Fedora Silverblue iso instead of ociarchive file #1362

Merged

Conversation

OhMyMndy
Copy link
Contributor

@OhMyMndy OhMyMndy commented Jul 3, 2024

Description

Make sure to download the iso for Fedora Silverblue instead of the ociarchive

Fixes #1257

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Packaging (updates the packaging)
  • Documentation (updates the documentation)

Checklist:

  • I have performed a self-review of my code
  • I have tested my code in common scenarios and confirmed there are no regressions
  • I have added comments to my code, particularly in hard-to-understand sections
  • I have made corresponding changes to the documentation (remove if no documentation changes were required)

Result with this change:

$ ./quickget fedora 40 Silverblue
Downloading Fedora 40 Silverblue
- URL: https://fedora.mirrorservice.org/fedora/linux/releases/40/Silverblue/x86_64/iso/Fedora-Silverblue-ostree-x86_64-40-1.14.iso

Before the change

$ quickget fedora 40 Silverblue
Downloading Fedora 40 Silverblue
- URL: https://mirrors.xtom.ee/fedora/releases/40/Silverblue/x86_64/images/Fedora-Silverblue-40.1.14.ociarchive

@OhMyMndy OhMyMndy changed the title Fix for downloading Fedora Silverblue fix: Downloading Fedora Silverblue iso instead of ociarchive file Jul 3, 2024
@OhMyMndy OhMyMndy force-pushed the fedora-silverblue-fix branch 2 times, most recently from b70b45d to 372be28 Compare July 3, 2024 14:07
@OhMyMndy OhMyMndy changed the title fix: Downloading Fedora Silverblue iso instead of ociarchive file fix: download Fedora Silverblue iso instead of ociarchive file Jul 3, 2024
@OhMyMndy OhMyMndy force-pushed the fedora-silverblue-fix branch from 372be28 to 49beb62 Compare July 3, 2024 14:08
Copy link
Member

@flexiondotorg flexiondotorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@flexiondotorg flexiondotorg merged commit 083ee16 into quickemu-project:master Jul 3, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: Silverblue VM not starting
2 participants