Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: collection of fixes and resolution for shellcheck warnings #1172

Merged
merged 38 commits into from
May 8, 2024
Merged

fix: collection of fixes and resolution for shellcheck warnings #1172

merged 38 commits into from
May 8, 2024

Conversation

flexiondotorg
Copy link
Member

No description provided.

flexiondotorg added 30 commits May 7, 2024 00:24
@flexiondotorg
fix(quickget): add daily-live to ubuntu-server
a2bc3f8
@flexiondotorg
chore(quickget): remove obsolete daily check from ubuntu
ec43639
@flexiondotorg
refactor: simplify get_tuxedo-os()
40385db
@flexiondotorg
fix(shellcheck): add missing local variable in get_truenas-scale()
6485c45
@flexiondotorg
style: add braces around variable names
2e4b8aa
@flexiondotorg
chore(quickget): remove obsolete logic for guix
9023809
@flexiondotorg
chore(quickget): remove how-to from code; added to the wiki
8f94fcf 
https://github.com/quickemu-project/quickemu/wiki/06-Advanced-quickget-features#adding-a-new-os-to-quickget
@flexiondotorg
docs: replace screenshot with asciinema
f39b730
@flexiondotorg
style(quickget): drop shorthand arguments for consistency
2977078 
quickemu has long hand command line arguments only. This commit removes the short hand arguments from the expanded capabilities introduced in quickget 4.9.3, so that both tools have a consistent user experience.
@flexiondotorg
style: update help_message() to remove shorthand arguments
044a1c1
@flexiondotorg
docs(README.md): update social links
44b4b2b
@flexiondotorg
docs(README.md): sign post the documentation for adding a new OS
ea38677
@flexiondotorg
refactor(quickget): special case image processing shellcheck compliant
da01185
@flexiondotorg
fix(quickget): make open_homepage() shellcheck compliant (SC2034)
b6c66e5 
https://www.shellcheck.net/wiki/SC2034
@flexiondotorg
fix(quickget): correct shellcheck SC2076 warnings
7415e8f 
https://www.shellcheck.net/wiki/SC2076
@flexiondotorg
refactor(quickget): remove single use function error_not_supported_os()
e1abe68
@flexiondotorg
style(quickget): make not supported release and edition output consis…
dec49fa 
…tent
@flexiondotorg
refactor(quickget): remove unnecessary string literals
efeb726
@flexiondotorg
fix(quickget): disable shellcheck SC2317 for cleanup()
188e88f 
https://www.shellcheck.net/wiki/SC2317
@flexiondotorg
fix(quickget): make show_os_info() shellcheck compliant
b8bf99d 
https://www.shellcheck.net/wiki/SC2086
@flexiondotorg
fix(quickget): make editions parsing shellcheck SC2207 compliant
3146193 
https://www.shellcheck.net/wiki/SC2207
@flexiondotorg
fix(quickget): disable shellcheck SC2207 warnings for ubuntu releases
9418f9c 
https://www.shellcheck.net/wiki/SC2207
@flexiondotorg
fix(quickget): disable SC2317 as many functions are called indirectly
a51410f 
https://www.shellcheck.net/wiki/SC2317
@flexiondotorg
fix(quickemu): disable shellcheck SC2054 and SC2140 warning
7af6ee0 
https://www.shellcheck.net/wiki/SC2054
https://www.shellcheck.net/wiki/SC2140
@flexiondotorg
fix(quickemu): resolve shellcheck SC2155 warnings
14ea71c 
https://www.shellcheck.net/wiki/SC2155
@flexiondotorg
fix(quickemu): resolve shellcheck SC2206 warnings
f0a3725 
https://www.shellcheck.net/wiki/SC2206
@flexiondotorg
fix(quickemu): resolve shellcheck SC2236
95e2d3c 
https://www.shellcheck.net/wiki/SC2236
@flexiondotorg
fix(quickemu): resolve shellcheck SC2069 warnings
076b194 
https://www.shellcheck.net/wiki/SC2069
@flexiondotorg
fix(quickemu): remove unused variable monitor_cmd SC2034
2beef37 
https://www.shellcheck.net/wiki/SC2034
@flexiondotorg
fix(quickemu): correct shellcheck SC2207 warnings
cea933b 
https://www.shellcheck.net/wiki/SC2207
@flexiondotorg flexiondotorg merged commit 6c2aad8 into master May 8, 2024
12 checks passed
@flexiondotorg flexiondotorg deleted the little-tweaks branch May 8, 2024 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@flexiondotorg