feat: Add font logos to os_info #1082
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It's working, but we don't want this in this release so changed to draft. Will be updated... |
require quickemu-font installed!
|
I have similar concerns to those expressed by @Finii. Closing this as out of scope. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Planned for future release
part 1: font logos implementation
require quickemu-font installed to see font logos properly!
Here isn't implementation for using them!
Only adding to os_info function
Currently included logos (font mostly broken in 0.0.3 release)
And here is screenshot of actual font: (0.0.2 working version)
So far my conversion of quickemu logo isn't sucesfull (font shows circle or square instead)
Older version of font also include some apps.
Font could be obtained from my repo:
https://github.com/oSoWoSo/quickemu-font-and-logos/releases/tag/v0.0.2
(newer version is broken, so use this one to see new fonts..)
closes #983