Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/reactive package container #63

Merged
merged 7 commits into from
Feb 15, 2024
Merged

Feat/reactive package container #63

merged 7 commits into from
Feb 15, 2024

Conversation

janbritz
Copy link
Contributor

@janbritz janbritz commented Oct 12, 2023 •
edited
Loading

Closes #62.

Über das Input-Element kann nach Paketen gesucht werden. Dafür wird der Such-Endpoint (#68) verwendet.
Die Tabs updaten sich hierbei "simultan" (300ms debounce).

image
image

Ein Loading-Indicator wird bei einem Request angezeigt.
image

Sollte hierbei oder beim Fetchen der Strings/Templates eine Exception geworfen werden, wird diese über ein Modal angezeit.

MHajoha
MHajoha previously requested changes Oct 12, 2023
View reviewed changes
classes/external/init_packages.php Outdated Show resolved Hide resolved
styles.css Show resolved Hide resolved
amd/src/container_component.js Outdated Show resolved Hide resolved
amd/src/container_component.js Outdated Show resolved Hide resolved
amd/src/container_component.js Outdated Show resolved Hide resolved
MartinGauk
MartinGauk previously requested changes Nov 3, 2023
View reviewed changes
Copy link
Contributor

@MartinGauk MartinGauk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ich würde diesen PR gerne pausieren und wir sollten versuchen die Arbeit in mehr Teilaufgaben zu trennen. Ich habe daher Issue #68 erstellt und würde dich bitten das zunächst zu bearbeiten.
Im Anschluss sollten wir uns überlegen, was eigentlich alles Teil des States sein sollte.

classes/external/init_packages.php Outdated Show resolved Hide resolved
@janbritz janbritz marked this pull request as draft January 16, 2024 09:37
@janbritz janbritz force-pushed the feat/reactive-package-container branch from 74fc7c0 to df99bd5 Compare January 16, 2024 12:13
@janbritz janbritz force-pushed the feat/reactive-package-container branch 4 times, most recently from 344547f to 4cd9ee1 Compare January 24, 2024 15:13
@janbritz janbritz force-pushed the feat/reactive-package-container branch from 13f87f0 to 25ff7a6 Compare January 29, 2024 08:06
@janbritz janbritz marked this pull request as ready for review January 29, 2024 08:39
@janbritz janbritz requested a review from larsbonczek January 29, 2024 08:42
@janbritz janbritz force-pushed the feat/reactive-package-container branch 2 times, most recently from 7f9aa7d to 45fb22b Compare January 29, 2024 09:00
@janbritz janbritz force-pushed the feat/reactive-package-container branch from 1e55e4c to 55fcd90 Compare January 30, 2024 14:35
larsbonczek
larsbonczek requested changes Feb 6, 2024
View reviewed changes
amd/src/package_search/reactive.js Outdated Show resolved Hide resolved
amd/src/package_search/mutations.js Outdated Show resolved Hide resolved
amd/src/package_search/mutations.js Outdated Show resolved Hide resolved
amd/src/package_search/mutations.js Outdated Show resolved Hide resolved
templates/package_search/area.mustache Outdated Show resolved Hide resolved
amd/src/package_search/components/search_bar.js Outdated Show resolved Hide resolved
amd/src/package_search/components/container.js Outdated Show resolved Hide resolved
amd/src/package_search/components/container.js Outdated Show resolved Hide resolved
amd/src/package_search/components/container.js Outdated Show resolved Hide resolved
styles.css
row-gap: 10px;
.qpy-package-search-container {
width: var(--qpy-card-width);
margin: 2px;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bitte nach Möglichkeit immer relative Einheiten verwenden (rem). Teste die styles auch für mobile Endgeräte.

@larsbonczek larsbonczek dismissed stale reviews from MartinGauk and MHajoha February 6, 2024 09:47

Outdated

@MHajoha MHajoha removed their request for review February 6, 2024 10:45
@janbritz janbritz force-pushed the feat/reactive-package-container branch 2 times, most recently from 3e694cc to 49c400f Compare February 8, 2024 10:38
@janbritz janbritz force-pushed the feat/reactive-package-container branch from 49c400f to bbde7cf Compare February 8, 2024 10:56
@janbritz janbritz mentioned this pull request Feb 8, 2024
Open
@janbritz janbritz requested a review from larsbonczek February 8, 2024 11:09
@janbritz janbritz mentioned this pull request Feb 8, 2024
Merged
@janbritz janbritz requested a review from larsbonczek February 12, 2024 11:06
@janbritz
Refactor/divide search area into more components (#92)
c4fdb21 
* refactor: divide search area into more components
* feat: add pagination for search container (#91)
* feat: add sorting for search container (#94)
@janbritz janbritz merged commit c8e3315 into dev Feb 15, 2024
10 checks passed
@janbritz janbritz deleted the feat/reactive-package-container branch February 15, 2024 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@larsbonczek larsbonczek larsbonczek approved these changes

@MHajoha MHajoha MHajoha left review comments

@alexanderschmitz alexanderschmitz Awaiting requested review from alexanderschmitz

@MartinGauk MartinGauk Awaiting requested review from MartinGauk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Erstellung eines reaktiven Such-Containers
4 participants
@janbritz @MartinGauk @MHajoha @larsbonczek