Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/19/package post #23

Merged
merged 8 commits into from
Dec 15, 2022
Merged

Feature/19/package post #23

merged 8 commits into from
Dec 15, 2022

Conversation

alexanderschmitz
Copy link
Contributor

solves #19

Neue route in der api: post_package entspricht /packages/{hash} serverseitig, wobei das berechnen des hash moodleseitig optional ist.

Die Form package_upload übernimmt das Rendern der Pakete und nicht mehr die upload_view.

@MartinGauk MartinGauk requested a review from MHajoha November 30, 2022 15:49
Copy link
Member

@MHajoha MHajoha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ich denke für die UX sollte der Upload später kein Popup sein, sondern ein Modal oder einfach ein filepicker in question_edit_form (bzw. anderen, je nach Kontext). Passt aber erstmal so. Ein Modal wäre vermutlich auch komplizierter.

classes/package.php Outdated Show resolved Hide resolved
classes/package.php Show resolved Hide resolved
Copy link
Member

@MHajoha MHajoha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Danke für die Änderung 👍

classes/package.php Show resolved Hide resolved
@alexanderschmitz alexanderschmitz merged commit 6725d91 into dev Dec 15, 2022
@MHajoha MHajoha deleted the feature/19/package_post branch January 2, 2023 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants