Fix showTables for Backwards Compatibility with name Property in QuestDB
#213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Upcoming QuestdB versions will change the column name from `name` -> `table_name` for `tables()` query. The web console is already using `table_name` property, but it should be backwards compatible with older versions of QuestDB. Once the new version of QuestDB is released, we can remove this backwards compatible code.
insmac
approved these changes
Oct 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
This PR includes a fix for the
showTablesfunction to ensure backwards compatibility with thenameproperty. The upcoming versions of QuestDB will change the column name fromnametotable_namefor thetables()query.The web console has already started using the
table_nameproperty, but it's crucial to maintain compatibility with older versions of QuestDB.Please note that this backwards compatibility code can be removed once the new version of QuestDB is released.
Commit log:
fix
showTablesto be backwards compatible withnamepropertyUpcoming QuestdB versions will change the column name from
name->table_namefortables()query.The web console is already using
table_nameproperty, but it should be backwards compatible with older versions of QuestDB.Once the new version of QuestDB is released, we can remove this
backwards compatible code.