chore(web-console): upgrade webpack, enable HMR #205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
will move them to webpack config next to babel-loader
* refactor dev/prod split * add babel config * remove `clean-webpack-plugin` for now, seems to be slow * ignore `.yarn` files where possible * split bundle output into 2 chunks: main and vendor * enable hot reload * use cheaper devtool * do not resolve symlinks (we use yarn PnP which doesn't do linking)
* avoid "catch all" package as it can explode the bundle in size (and compile time)
this enables webpack to tree-shake the library
this enables tree shaking and hot reload
argshook
changed the title
insmac
previously approved these changes
Oct 10, 2023
* shorter hashes * hashes on all bundles * guarantess killing browser cache when we release versions
insmac
approved these changes
Oct 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description:
Update webpack and webpack-dev-server, remove externalized babel configs, refactor dev/prod split in webpack config, add babel config, remove slow clean-webpack-plugin, ignore .yarn files, split bundle output into main and vendor chunks, enable hot reload, use cheaper devtool, do not resolve symlinks, use explicit styled icons packages to avoid bundle size explosion, tidier code with no notable changes, mark react-components as side effects free to enable webpack tree-shaking, and build react-components with esNext modules for tree shaking and hot reload.
Commit log:
will move them to webpack config next to babel-loader
clean-webpack-pluginfor now, seems to be slow.yarnfiles where possiblereact-componentsas side effects freethis enables webpack to tree-shake the library
this enables tree shaking and hot reload