WIP: Update tests suite for the UI refresh

questdb · Sep 22, 2023 · 8599e04 · 8599e04
1 parent 074b382
commit 8599e04
Show file tree

Hide file tree

Showing 7 changed files with 19 additions and 22 deletions.
diff --git a/packages/browser-tests/cypress/commands.js b/packages/browser-tests/cypress/commands.js
@@ -121,4 +121,10 @@ Cypress.Commands.add("getSelectedLines", () => cy.get(".selected-text"));
 
 Cypress.Commands.add("getVisibleLines", () => cy.get(".view-lines"));
 
-Cypress.Commands.add("getNotifications", () => cy.get(".notifications"));
+Cypress.Commands.add("getCollapsedNotifications", () =>
+  cy.get('[data-hook="notifications-collapsed"]')
+);
+
+Cypress.Commands.add("getExpandedNotifications", () =>
+  cy.get('[data-hook="notifications-expanded"]')
+);
diff --git a/packages/browser-tests/cypress/integration/console/editor.spec.js b/packages/browser-tests/cypress/integration/console/editor.spec.js
@@ -249,7 +249,7 @@ describe("errors", () => {
     cy.typeQuery(query).runLine();
     cy.matchErrorMarkerPosition({ left: 506, width: 42 });
 
-    cy.getNotifications().should("contain", "Invalid date");
+    cy.getCollapsedNotifications().should("contain", "Invalid date");
   });
 });
 

diff --git a/packages/browser-tests/cypress/integration/console/grid.spec.js b/packages/browser-tests/cypress/integration/console/grid.spec.js
@@ -21,13 +21,13 @@ describe("questdb grid", () => {
     cy.wait(100);
 
     cy.getGridRows()
-      .should("have.length", 8)
+      .should("have.length", 9)
       .getGridRow(0)
       .should("contain", "1");
 
     cy.getGridViewport().scrollTo("bottom");
-    cy.getGridRows().should("have.length", 8);
-    cy.getGridRow(0).should("contain", "93");
+    cy.getGridRows().should("have.length", 9);
+    cy.getGridRow(0).should("contain", "92");
     cy.matchImageSnapshot();
   });
 

diff --git a/packages/browser-tests/cypress/integration/console/settings.spec.js b/packages/browser-tests/cypress/integration/console/settings.spec.js
diff --git a/packages/web-console/src/scenes/Console/index.tsx b/packages/web-console/src/scenes/Console/index.tsx
@@ -39,8 +39,10 @@ const Bottom = styled.div`
   flex: 1;
 `
 
-const ToggleTablesIcon = styled(ChevronDoubleLeft)<{ collapsed: boolean }>`
-  transform: rotate(${({ collapsed }) => (collapsed ? "180deg" : "0deg")});
+const ToggleTablesIcon = styled(ChevronDoubleLeft)<{ splitterbasis: number }>`
+  transform: rotate(
+    ${({ splitterbasis }) => (splitterbasis === 0 ? "180deg" : "0deg")}
+  );
 `
 
 const viewModes: {
@@ -109,7 +111,7 @@ const Console = () => {
                   >
                     <ToggleTablesIcon
                       size="16px"
-                      collapsed={resultsSplitterBasis === 0}
+                      splitterbasis={resultsSplitterBasis}
                     />
                   </Button>
                 }

diff --git a/packages/web-console/src/scenes/Notifications/index.tsx b/packages/web-console/src/scenes/Notifications/index.tsx
@@ -129,7 +129,7 @@ const Notifications = () => {
           <TerminalBoxIcon size="18px" />
           Log
         </Header>
-        <LatestNotification>
+        <LatestNotification data-hook="notifications-collapsed">
           {isMinimized && lastNotification && (
             <Notification isMinimized={true} {...lastNotification} />
           )}
@@ -140,7 +140,7 @@ const Notifications = () => {
       </Menu>
       {!isMinimized && (
         <Content minimized={isMinimized} ref={contentRef}>
-          <TransitionGroup className="notifications">
+          <TransitionGroup data-hook="notifications-expanded">
             {notifications.map((notification) => (
               <Notification
                 isMinimized={false}

diff --git a/packages/web-console/src/scenes/Schema/index.tsx b/packages/web-console/src/scenes/Schema/index.tsx
@@ -315,6 +315,7 @@ const Schema = ({
           skin="secondary"
           onClick={() => dispatch(actions.console.setActivePanel("import"))}
           prefixIcon={<Upload2 size="18px" />}
+          data-hook="navigation-import-button"
         >
           Import
         </Button>